Skip to content

fix: use PriceHawk icon in dashboard nav and favicon#11

Merged
Artic0din merged 1 commit into
mainfrom
fix/dashboard-icon-nav
Apr 6, 2026
Merged

fix: use PriceHawk icon in dashboard nav and favicon#11
Artic0din merged 1 commit into
mainfrom
fix/dashboard-icon-nav

Conversation

@Artic0din
Copy link
Copy Markdown
Owner

Summary

  • Replace CSS gradient "P" in nav bar with actual PriceHawk icon.png
  • Add favicon pointing to /local/pricehawk/icon.png
  • Update dashboard_config.py to copy icon.png to www/pricehawk/ on setup

Follow-up to PR #10 — the icon files landed but the dashboard HTML and config changes were missed.

🤖 Generated with Claude Code

- Replace CSS gradient "P" with actual icon.png in nav bar
- Add favicon link to icon.png
- Update dashboard_config.py to copy icon.png to www/pricehawk/
  alongside the existing SVG icon

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Artic0din Artic0din merged commit a652f37 into main Apr 6, 2026
2 of 3 checks passed
@Artic0din Artic0din deleted the fix/dashboard-icon-nav branch April 6, 2026 06:36
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 817b4c04-dbbd-4284-b0ec-aba135ae934e

📥 Commits

Reviewing files that changed from the base of the PR and between 0617419 and ccc7f1c.

📒 Files selected for processing (2)
  • custom_components/pricehawk/dashboard_config.py
  • custom_components/pricehawk/www/dashboard.html

📝 Walkthrough

Summary by CodeRabbit

  • UI/UX Improvements
    • Added favicon support to dashboard for browser tab display
    • Updated navigation logo from text-based design to image-based rendering
    • Enhanced dashboard visual styling and consistency

Walkthrough

Updates the asset copying logic to handle PNG icon files and modifies the dashboard HTML to display an image-based logo with favicon support, replacing the previous text-based design element.

Changes

Cohort / File(s) Summary
Asset Handling Configuration
custom_components/pricehawk/dashboard_config.py
Modified copy_www_assets function to use Path-based source paths, introduce conditional copying of icon.png, and write inline SVG icon to a renamed destination variable. Variable names and path construction adjusted for icon asset management.
Dashboard UI & Styling
custom_components/pricehawk/www/dashboard.html
Added favicon link to reference PNG icon, replaced text-based nav brand logo with image-based logo using <img> element, updated CSS styling for image sizing and fit, and removed light-mode specific text color rule.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dashboard-icon-nav

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant