don't override PREFIX target property#340
Merged
ArthurSonzogni merged 1 commit intoArthurSonzogni:masterfrom Feb 19, 2022
ericLemanissier:patch-1
Merged
don't override PREFIX target property#340ArthurSonzogni merged 1 commit intoArthurSonzogni:masterfrom ericLemanissier:patch-1
ArthurSonzogni merged 1 commit intoArthurSonzogni:masterfrom
ericLemanissier:patch-1
Conversation
4 tasks
Contributor
|
@ericLemanissier it looks like this microsoft/vcpkg#16327 (comment) is the issue that required the ftxui- prefix. |
Contributor
Author
|
AFAIU, this issue is fixed because the libraries are in the lib folder now |
PREFIX is by default "lib", which most of the libraries use. this changes makes the library files libftxui-foo.a as #140 intended originally
Owner
|
Thanks! This sounds good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PREFIX is by default "lib", which most of the libraries use.
this changes makes the library files libftxui-foo.a
as #140 intended originally