Merged
Conversation
Owner
Author
|
Hi @myd7349, could you please take a look? |
Instead of putting the archive as: - <lib_dir>/ftxui/libcomponent.a - <lib_dir>/ftxui/libdom.a - <lib_dir>/ftxui/libscreen.a Use: - <lib_dir>/libftxui-component.a - <lib_dir>/libftxui-dom.a - <lib_dir>/libftxui-screen.a This fixes an issue users have with VCPKG. See: microsoft/vcpkg#16327 (comment)
ArthurSonzogni
force-pushed
the
vcpkg-rename-lib
branch
from
f2ba6f0 to
39562fa
Compare
Contributor
|
Hi! @ArthurSonzogni Sorry for the long delay. microsoft/vcpkg#18360 is already merged, without this patch however. |
ArthurSonzogni
pushed a commit
that referenced
this pull request
Feb 19, 2022
PREFIX is by default "lib", which most of the libraries use. this changes makes the library files libftxui-foo.a as #140 intended originally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of putting the archive as:
Use:
This fixes an issue users have with VCPKG.
See:
microsoft/vcpkg#16327 (comment)