fix(i18n): add Memo CardSets to Fallacies CardSetLocalization (#358) - #381
Merged
Conversation
Memo + MemoPrintAndPlay reuse the FallaciesTaxonomy dataset and the same
{{text_fr}}, {{desc_fr}}, {{Famille}}, {{Sous-Famille}}, {{Soussousfamille}}
template placeholders. Without entries in CardSetLocalizations, the FR
placeholders are never swapped at runtime → MEMO pages on EN/RU/PT/AR/ES/ZH/FA
PDFs render FR content.
Same root cause as #216 (Fallacies multilingual content was broken until
PR #347 in April 2026). Fix: append KnownCardSets.Memo and
KnownCardSets.MemoPrintAndPlay to the existing Fallacies CardSetLocalization
entry — same dataset, same placeholders, same conversions.
Acceptance criteria (#358):
- MEMO Tarot + MEMO Print&Play render translated content on EN/RU/PT ✓ (by config)
- MEMO renders correctly on AR/ES/ZH/FA ✓ (already in conversion lists from #361)
- PDF visual regression test (#212) is tracked separately
Pipeline regen required to produce the corrected PDFs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
KnownCardSets.MemoandKnownCardSets.MemoPrintAndPlayto the existing Fallacies entry inLocalizationConfig.CardSetLocalizations. Resolves #358.Root cause
MEMO templates (
Cards/Memo/Argumentum_Memo_Face_fr.json+Argumentum_Memo_Back_fr.json) use the same placeholders as Fallacies ({{text_fr}},{{desc_fr}},{{Famille}},{{Sous-Famille}},{{Soussousfamille}}) and the same dataset (KnownDataSets.FallaciesTaxonomy). Without aCardSetLocalizationentry mapping_fr→_en/_ru/_pt/_es/_ar/_fa/_zh, thetemplate.Replace()step in the LocalizationConfig pipeline never runs for Memo → output stays in FR.Same class of bug as #216 (Fallacies multilingual content was broken until PR #347 in April 2026).
Minimal change
Appended Memo + MemoPrintAndPlay to the existing Fallacies CardSetNames list — no new entry needed because mappings are identical (same dataset, same placeholders, same hierarchy fields). Memo Back template does not use
tagline_fr, so the existing BackFieldConversions are a no-op for Memo (harmless).CardSetNames = new List<string>(new [] { KnownCardSets.Fallacies, KnownCardSets.Fallacies2, KnownCardSets.Fallacies3, KnownCardSets.FallaciesPrintAndPlay, KnownCardSets.FallaciesWeb, - KnownCardSets.FallaciesWebThumbnails + KnownCardSets.FallaciesWebThumbnails, + KnownCardSets.Memo, + KnownCardSets.MemoPrintAndPlay }),Acceptance (from #358)
Test plan
TarotCards_*-1.pdfp28-31 (range cited in MEMO cards display French content on EN/RU/PT/AR/ES/ZH/FA PDFs (missing CardSetLocalization) #358) for at least 3 languagesFamille_camelCaseCSS class still works (it's a Mustache helper output, not a localized field — unchanged)Pipeline regen + visual diff to be batched with PRs #353 v2 + #355 to share one full pipeline run (cf. #358 priority note).
🤖 Generated with Claude Code