fix(fallacies): clean corrupted link_fr/link_pt cells (#334) - #347
Merged
Conversation
…ned rows (#334) - Remove 6 GUIDs from link_fr (rows 350, 638, 821, 822, 853, 1390) - Remove prose from link_pt (rows 373, 610) - Remove numeric IDs from link_fr (rows 373, 610) - Fix corrupted URL encoding in link_fr row 6 - Fix page title instead of URL in link_fr row 231 - Fix double-URL concatenation in link_fr row 9 - Fix 2 rows (373, 610) with 103 cols due to unquoted commas in desc_fr Closes #334 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
4 tasks
This was referenced May 24, 2026
Closed
jsboige
added a commit
that referenced
this pull request
May 28, 2026
…381) Memo + MemoPrintAndPlay reuse the FallaciesTaxonomy dataset and the same {{text_fr}}, {{desc_fr}}, {{Famille}}, {{Sous-Famille}}, {{Soussousfamille}} template placeholders. Without entries in CardSetLocalizations, the FR placeholders are never swapped at runtime → MEMO pages on EN/RU/PT/AR/ES/ZH/FA PDFs render FR content. Same root cause as #216 (Fallacies multilingual content was broken until PR #347 in April 2026). Fix: append KnownCardSets.Memo and KnownCardSets.MemoPrintAndPlay to the existing Fallacies CardSetLocalization entry — same dataset, same placeholders, same conversions. Acceptance criteria (#358): - MEMO Tarot + MEMO Print&Play render translated content on EN/RU/PT ✓ (by config) - MEMO renders correctly on AR/ES/ZH/FA ✓ (already in conversion lists from #361) - PDF visual regression test (#212) is tracked separately Pipeline regen required to produce the corrected PDFs. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
link_frandlink_ptcolumns of Fallacies taxonomy CSVdesc_frChanges
Verification
git diff --stat: 11 insertions, 11 deletions (surgical)csv.writer(QUOTE_MINIMAL)per validated recipeCloses #334
🤖 Generated with Claude Code