data(rules): gpt-5.5 quality cleanup for AR/ES/FA/ZH - #362
Merged
Conversation
clusterManager-Myia
approved these changes
May 27, 2026
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
Collaborator
There was a problem hiding this comment.
[Hermes] — APPROVED
PR: data(rules): gpt-5.5 quality cleanup for AR/ES/FA/ZH
SHA: 05a7d0a
Checklist
- Security scan: CLEAN
- Cross-repo impact: None (i18n data only)
- CI: ✅ GitGuardian pass, Debug/Release build pass
Analyse
- Data-only PR : corrections de traduction sur 4 fichiers CSV pour ZH, FA, ES, AR
- Terminologie unifiée de manière cohérente (ex: embromador → embaucador, 扯皮者 → 花言巧语者)
- Pas de logique métier, pas de code, pas de risque de régression
Raison : PR data-only i18n, CI verte, security clean. Approve rapide.
…ells) Re-pass Rules AR/ES/FA/ZH translations using gpt-5.5 (quality tier) via DatasetUpdater cleanup pattern (SelectEmptyTargets=false, NbGlobalPasses=2). 35/96 cells (36%) improved for semantic accuracy and fidelity to FR canonical. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jsboige
force-pushed
the
data/rules-cleanup-gpt55
branch
from
May 27, 2026 02:09
05a7d0a to
28c662c
Compare
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
Collaborator
There was a problem hiding this comment.
[Hermes] COMMENT_WITH_CONCERNS (re-review after new commit 28c662c)
Previous: APPROVED on 05a7d0a. New commit adds 35 corrections.
Checklist: Security CLEAN | Cross-repo None | CI pass
Concern 1 (non-bloquant): Typo double point introduit en ES (charlatán..) et pré-existant en FA. Corriger le double point ES.
Verdict: Non-bloquant. Nettoyage terminologique cohérent.
clusterManager-Myia
approved these changes
May 27, 2026
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
Collaborator
There was a problem hiding this comment.
[NanoClaw]
Verified CSV translation quality across 4 languages (AR/ES/FA/ZH):
- ES: embromador → embaucador, robador → quien roba (consistent, better register)
- ZH: 扯皮者 → 花言巧语者 (more evocative, matches character role)
- FA: منصرفکننده → چربزبان (Persian idiom, consistent through all rules)
- AR: minor grammar fixes
+117/-117 — balanced replacements, no structural changes. Data-only. LGTM.
jsboige
added a commit
that referenced
this pull request
May 27, 2026
#363) - Fill ES fields for 220/223 Virtues entries via DatasetUpdater (gpt-5.5) - Coverage: title_es 220/223, description_es 220/223, remark_es 220/223, family_es 220/223, subfamily_es 212/223, subsubfamily_es 192/223, link_es 117/223 - Normalize 4 inconsistent subfamily/subsubfamily translations - Add ES translation prompts (user + assistant) - Add DatasetUpdater task config for Virtues ES (disabled after run) - Disable Fallacies cleanup task (leftover from PR #362) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com