fix(fallacies): fill 2 empty desc_en (PK 371, 607) surgically — supersedes #343 - #344
Merged
Merged
Conversation
…sedes #343 #343 inserted PK 371's desc_en unquoted; its embedded comma split the field, shifting all 103->104 downstream columns for that row (desc_ru/pt/ar/es/zh/fa all misaligned). The +2/-2 git stat and csv.DictReader test masked it. This version writes both desc_en via csv.writer QUOTE_MINIMAL + CRLF (PK 371 properly quoted for its comma), preserving master's byte format. Verified cell-by-cell: exactly 2 cells changed (both desc_en), PK 371 back to 103 columns, no BOM, CRLF preserved, no other field touched. PK 371 (Warm reading): "You make psychological observations vague enough to apply to anyone, as if you could read minds." PK 607 (Nutpicking): "You generalize the traits of a group's worst members to the entire group." Closes #343 (superseded). Part of #335 P2 (Fallacies taxonomy gaps). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills the 2 remaining empty
desc_encells in the Fallacies taxonomy CSV:2.3.1.1.2.1.1, Lecture à chaud / Warm reading)3.1.1.2.3.1, Cueillette des noix / Nutpicking)This is the last data residual for the Fallacies taxonomy (already ~100% translated EN/RU/PT — verified cell-by-cell). Completes P2 of the v0.9.0 data-gate.
Why this supersedes #343
#343 wrote PK 371's
desc_enunquoted. That value contains a comma ("...apply to anyone, as if..."), so the comma split the field → all downstream columns on row 371 shifted by +1 (103→104 cols), misaligningdesc_ru/desc_pt/desc_ar/desc_es/ etc. on that row. The+2/−2line-diff and acsv.DictReadersmoke test both masked it (line-counting and DictReader silently absorb extra columns).This branch fixes it by serialising with
csv.QUOTE_MINIMAL(which correctly quotes the comma-bearing value) + CRLF, autocrlf disabled.Surgical verification (cell-by-cell, vs
origin/master)desc_en(PK 371 + 607) — nothing else touched504b 2c= "PK,")Closes #343 (superseded).
Part of #335 (P2 — Fallacies taxonomy gaps).
🤖 Generated with Claude Code