Skip to content

fix(fallacies): fill 2 empty desc_en fields (PK 371, 607) - #343

Closed
jsboige wants to merge 1 commit into
masterfrom
fix/fallacies-desc-en-371-607
Closed

fix(fallacies): fill 2 empty desc_en fields (PK 371, 607)#343
jsboige wants to merge 1 commit into
masterfrom
fix/fallacies-desc-en-371-607

Conversation

@jsboige

@jsboige jsboige commented May 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fill 2 empty desc_en fields in Cards/Fallacies/Argumentum Fallacies - Taxonomy.csv
    • PK 371 (Warm reading, path 2.3.1.1.2.1.1): "You make psychological observations vague enough to apply to anyone, as if you could read minds."
    • PK 607 (Nutpicking, path 3.1.1.2.3.1): "You generalize the traits of a group's worst members to the entire group."

Scope

  • 1 file, 2 insertions / 2 deletions — surgical edit (no re-serialization)
  • Only desc_en touched. FR/RU/PT/Latin/all other fields untouched.

Test plan

  • csv.DictReader parses correctly with new values
  • git diff --stat = 2+/2- (surgical, no re-serialization)
  • Visual spot-check of the 2 rows in the CSV

Part of issue #335 P2 (Fallacies taxonomy gaps).

🤖 Generated with Claude Code

PK 371 (Warm reading): "You make psychological observations vague enough to apply to anyone, as if you could read minds."
PK 607 (Nutpicking): "You generalize the traits of a group's worst members to the entire group."

Surgical edit: 2 insertions, 2 deletions. FR/RU/PT/Latin untouched.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jsboige

jsboige commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #344. #343 corrupted row PK 371: its desc_en value contains a comma and was written unquoted, splitting the field → all downstream columns on that row shifted by +1 (103→104), misaligning desc_ru/desc_pt/etc. The +2/−2 line-diff and the csv.DictReader smoke test both masked it. #344 fixes both cells with csv.QUOTE_MINIMAL (quotes the comma) + CRLF, verified byte-surgical (exactly 2 cells changed, PK 371 back to 103 cols). Thanks for the work — see #344 for the corrected approach.

@jsboige jsboige closed this May 23, 2026
@jsboige
jsboige deleted the fix/fallacies-desc-en-371-607 branch May 23, 2026 19:22
jsboige added a commit that referenced this pull request May 23, 2026
…1-607-final

fix(fallacies): fill 2 empty desc_en (PK 371, 607) surgically — supersedes #343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant