LttP: fix single-player no-logic generation #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #3438 |
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
is: bug/fix
NewSoupVi
approved these changes
Jun 12, 2024
| """ | ||
| Add OWG transitions to no logic player's world | ||
| """ | ||
| create_no_logic_connections(player, world, get_boots_clip_exits_lw(world.mode[player] == 'inverted')) |
There was a problem hiding this comment.
create_no_logic_connections is now unused as well, idk if you wanna remove that too
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
As far as I could tell, overworld_glitch_connections is a direct copy of no_logic_rules, and in single-player no-logic both get run, creating duplicated connections. Those dupes then trip the cache's checker.
How was this tested?
By seeing the gen no longer error and the playthrough looking correct. Which for no-logic is:
0: {}
I'd appreciate some no-logic players confirming this didn't break something unanticipated though.
If this makes graphical changes, please attach screenshots.