Pokemon Emerald: Fix client crash if 0.4.6 client connects to 0.4.5 seed #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zunawe
added
the
is: bug/fix
github-actions
bot
added
the
waiting-on: peer-review
|
Forgot to mention, this is because of #3069. I was expecting a few more changes might happen between, including potentially a patch update, which would have made backwards compatibility nonviable anyway. Otherwise I'd have probably included this in that PR. |
ScipioWright
approved these changes
Apr 15, 2024
Berserker66
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
A client on
mainconnecting to a seed generated on 0.4.5 will encounter an exception if the player is playing legendary hunt, catches Ho-Oh, and Ho-Oh is a valid legendary hunt encounter.This is the only thing needed to make the client backwards compatible.
Also bumps the required client version to avoid the crash in the other direction, where a game is generated on main/0.4.6 and a player attempts to connect with a 0.4.5 client.
How was this tested?
Generated on 0.4.5, set the Ho-Oh flag, and ran on
mainand this branch.mainhit an exception, this branch fixed it.