Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon Emerald: Change Ho-Oh capitalization #3069

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

Zunawe
Copy link
Collaborator

@Zunawe Zunawe commented Apr 1, 2024

What is this fixing or adding?

Changes the capitalization of Ho-oh to Ho-Oh, which is consistent with the way it's capitalized in newer generations.

Screencap from ORAS:
Capture

How was this tested?

Generated using "Ho-Oh" in allowed_legendary_hunt_encounters and wild_encounter_blacklist. Searched for every instance of ho.?oh in the code and changed any with the wrong capitalization.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 1, 2024
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho-Oh
LGTM, all changes are strings

@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 5, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM, couldn't find any other instances that need changing

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 5, 2024
@Berserker66 Berserker66 merged commit cf59cfa into ArchipelagoMW:main Apr 11, 2024
15 checks passed
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Zunawe Zunawe deleted the emerald-ho-oh branch May 23, 2024 08:43
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants