-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add Spanish Guide for Pokemon Emerald #2696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
muy buena traduccion, pero ocupa algunos cambios gramaticales y de redaccion:
general:
-no se si traducir el titulo del juego sea correcto, especialmente si no se va a usar la version en español, personalmente lo dejaria simplemente como Emerald, pero no creo que sea algo grave (aunque si otra persona que hable ingles te dice que lo cambies, deberias hacerlo)
linea 1: Guía lleva tilde, y el segundo "de" lo cambiaria por un "para", para que suene mejor
linea 6: en vez de "inglesa" yo pondria "en inglés", suena mejor
linea 7: en vez de "superior" yo pondria "posterior" (aunque es subjetivo)
linea 14: "reincia" esta mal escrito, es reinicia
linea 15: la palabra correcta es "desconexiones"
linea 18: "click" se traduce como "clic"
linea 20: una coma despues de "limpiarlas" no vendria mal, ya que la lectura de la frase cambia con la traduccion
linea 35: "Seleccióna" no lleva tilde
linea 43: aqui cortaste la palabra Archipelago, continúa lleva tilde, y BizHawk esta mal escrito
linea 47: Aun no lleva tilde en este contexto
linea 48: la forma correcta es "en caso de que"
linea 50: Pokémon lleva tilde en la e, no en la o
linea 52: Asegúrate lleva tilde
linea 57: reconocerá lleva tilde, y otra vez Pokémon tiene mal el tilde
linea 61: ítems lleva tilde
linea 72: símbolo lleva tilde
linea 74: vacío lleva tilde
eso es todo lo que compete a la traduccion en si, aun te falta incorporar el codigo de referencia del tutorial en el init.py de pokemon emerald, pero vamos por parte
Corregido. Lo del Init.py desconozco es la primera vez que colaboro. |
Thanks a bunch for the translation. In It might look like this: class PokemonEmeraldWebWorld(WebWorld):
"""
Webhost info for Pokemon Emerald
"""
theme = "ocean"
setup_en = Tutorial(
"Multiworld Setup Guide",
"A guide to playing Pokémon Emerald with Archipelago.",
"English",
"setup_en.md",
"setup/en",
["Zunawe"]
)
setup_es = Tutorial(
"translated text",
"translated text",
"Español",
"setup_es.md",
"setup/es",
["nachocua"]
)
tutorials = [setup_en, setup_es] You can look at I'm not sure why many translated pages maintain the English page title and description. |
Ready. |
it seems like there isn't a standard for this, last time I asked in #archipelago-dev people were divided about it (and after all, the only foreign guide that uses translated titles and descriptions is the french guide for Adventure), so there wasn't a solid position (hence I haven't done it in my guides) in any case,
this wasn't literal, you must translate the actual lines from the english code strings
once that is done I believe it's ready |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bueno, con los ultimos cambios diria que esta muy bien la traduccion, por mi parte la apruebo
si tuviera que ajustar algo, seria en el titulo, en mi opinion "para Pokémon Emerald" suena mejor que "de Pokémon Emerald", y en la linea 11 queda mejor "y cambia las siguientes" que "y haz cambio en las siguientes", pero son cosas totalmente subjetivas
buen trabajo
Gracias. Quieres que haga esos cambios? no tengo problema |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokémon Emerald * Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokemon Emerald
* Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokémon Emerald * Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokemon Emerald
* Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokémon Emerald * Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokemon Emerald
* Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokémon Emerald * Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokemon Emerald * Docs: Add Spanish Guide for Pokemon Emerald
What is this fixing or adding?
Adding a Spanish guide configuration for Pokemon Emerald
How was this tested?
Markdown online test
If this makes graphical changes, please attach screenshots.