-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Witness: Local Laser Shuffle + Option Presets #2590
Conversation
I would request a review from someone who plays The Witness on whether these presets make sense, before this PR is merged As for the "Short & Dense" setting: I played this recently in a short sync on a whim and found it incredibly fun, because it's super fast but it feels packed with content because you're only solving non-trivial randomized puzzles and can usually fully clear areas. It's like Sigma any%/Sigma AL but forcing a different order. I personally played it with local laser shuffle as well but "local_items" is not support by presets I believe. The other two should be self explanatory :) |
The printout "[Player]'s Witness world doesn't have any progression items. Please turn on Symbol Shuffle, Door Shuffle or Laser Shuffle." can seem a little strange with |
Maybe be more specific in the message stating you need items to place in other worlds? If we allow laser_shuffle: local to count for that, the Witness player will have all of their progression items be forced into their own world, which is effectively the same as off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, not a Witness player so can't speak to the quality of the presets.
…recommendation tbh
Alright, I changed those messages to be a bit more sensible and specific and accurate :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes all look good to me, including the presets
This PR depends on #2631 now Edit: IT'S PASSING UNIT TESTS??? |
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Added option presets.
One of the option presets relies on laser_shuffle: True with local lasers, which option presets don't support.
However, "shuffle_lasers: local" has actually been an option we have been considering adding for a while anyway, because it is a very popular setting.
Note: Every other place in the code should behave as expected in regards to the change in the laser shuffle option, as there is functionally no difference between "local" and "anywhere", and
if self.options.laser_shuffle
will resolve as True for both "local" and "anywhere" and as False for "off".Tested:
Ran webhost locally and confirmed that the presets worked and no errors happened in the python console or browser console
Generated a couple of seeds to see whether local lasers works as intended
Btw: I know the comments don't show on the website, they're more for other ppl looking at the code