-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebHost: Refactor tracker.py
, removal of dead code, and tweaks to layouts of some tracker pages.
#2438
Conversation
Requested reviews from all relevant world owners (and @jonloveslegos / @lordlou as you both haven't accepted collaborator invite) since I touched your world's tracker code. Also Farrak for the WebHost front-end changes. |
Some form of these changes will be required to complete #1933. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for SC2 as long as it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do have a minor UX flow issue.
The generic multiworld tracker has this UI:
Clinking on the slot for LttP gives you this:
And clicking on "Switch to Generic Tracker" gives you this:
Which returns to the multiworld tracker, which is labelled "Generic."
Not a huge issue, and I think people will figure out the flow easily enough, but I guarantee some will be confused.
Other than that, HTML / CSS / JS looks good to me.
line-height: 20px; | ||
gap: 0.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RIP Internet Explorer users 🤣.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
I didnt do the SM tracker. I think its @TauAkiou. |
…ayouts of some tracker pages. (ArchipelagoMW#2438)
What is this fixing or adding?
This is a huge refactor of
tracker.py
in WebHost and depending files.Tracker API Changes:
item_id_to_name
/location_id_to_name
lookup tables.worlds/__init__.py
as they are no longer needed.network_data_package
only to check if game exists in datapackage to prevent WebHost from loading the tracker if relevant world folder/apworld is removed on same machine WebHost is running from.Multiworld/Player Template Changes:
CustomServer Changes:
!video
command doccomment.MISC Changes:
lookup_any_item_id_to_name
andlookup_any_location_id_to_name
functions.data_version
: 0 as it doesn't current do anything in AP core anyway.checksum
s, which will be dropped in Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) #1933, anyway.How was this tested?
Thoughoughly generated multiple rooms with a variety of games that both include and do not include custom trackers.
If this makes graphical changes, please attach screenshots.