-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: log fill progress #2382
Core: log fill progress #2382
Conversation
I feel like this is confusing if you don't know that there are multiple fills gonna happen. |
I was hoping "current fill step" would indicate there are multiple. Printing for each step is quite verbose, as we have many. I don't like hiding it either. I could add another for remaining_fill, which would almost always at least do it twice, hence making it more obvious there's multiple. |
So, my two suggestions are either |
I agree with the first 2 suggestions from el-u. For 3-4, I am not sure how it's formatted elsewhere, but preferably it should be consistent. For 5, I think the current naming is as good as the suggested one, as it fills (some) dungeon items into (some) dungeons. Lgtm otherwise. |
Co-authored-by: el-u <[email protected]>
Co-authored-by: el-u <[email protected]>
* Core: log fill progress * Add names to common fill steps * Update Fill.py Co-authored-by: el-u <[email protected]> * Apply suggestions from code review Co-authored-by: el-u <[email protected]> * cleanup default name --------- Co-authored-by: el-u <[email protected]>
* Core: log fill progress * Add names to common fill steps * Update Fill.py Co-authored-by: el-u <[email protected]> * Apply suggestions from code review Co-authored-by: el-u <[email protected]> * cleanup default name --------- Co-authored-by: el-u <[email protected]>
What is this fixing or adding?
Some alive signals during a long fill step
How was this tested?
with 300 Factorio worlds
If this makes graphical changes, please attach screenshots.