-
Notifications
You must be signed in to change notification settings - Fork 909
DS3: Added 'Early Banner' Setting #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
200a78a
make setting for early lothric banner
Br00ty 746490c
changed setting to call `early_items` instead of `local_early_items`
Br00ty 3a07006
Merge branch 'ArchipelagoMW:main' into ds3-early-banner
Br00ty 5e558a9
Merge branch 'ArchipelagoMW:main' into ds3-early-banner
Br00ty a062c25
Merge branch 'ArchipelagoMW:main' into ds3-early-banner
Br00ty df1c2ae
Merge branch 'ArchipelagoMW:main' into ds3-early-banner
Br00ty af5abd5
Merge branch 'ArchipelagoMW:main' into ds3-early-banner
Br00ty db6f87e
Merge branch 'ArchipelagoMW:main' into ds3-early-banner
Br00ty 7ac393d
Merge branch 'main' into ds3-early-banner
Br00ty f2a9f30
Merge branch 'ArchipelagoMW:main' into ds3-early-banner
Br00ty 0b3d5d9
Merge branch 'main' into ds3-early-banner
Br00ty a578e55
Merge branch 'ArchipelagoMW:main' into ds3-early-banner
Br00ty 69fab6a
Merge branch 'main' into ds3-early-banner
Br00ty fb63c6c
Merge branch 'main' into ds3-early-banner
Br00ty 4b53659
Merge branch 'main' into ds3-early-banner
Br00ty 843194c
Merge branch 'main' into ds3-early-banner
Br00ty 5df7560
Merge branch 'main' into ds3-early-banner
Br00ty fb02922
Merge branch 'main' into ds3-early-banner
Br00ty cc3c83e
Merge branch 'main' into ds3-early-banner
Br00ty d37b454
Merge branch 'main' into ds3-early-banner
Br00ty bd2ac60
Merge branch 'main' into ds3-early-banner
Br00ty e3812a1
changed it so the user can decide on where the early banner should be…
Br00ty 580b6de
move the settings to be under `key locations`
Br00ty a1c3bbb
Merge branch 'main' into ds3-early-banner
Br00ty b4db4e0
Merge branch 'main' into ds3-early-banner
Br00ty 7ee4028
Update Options.py
Br00ty 1cb1dc1
Update __init__.py
Br00ty a29c8bf
Merge branch 'main' into ds3-early-banner
Br00ty 0930f06
Merge branch 'main' into ds3-early-banner
Br00ty ab405d9
Update worlds/dark_souls_3/__init__.py
Br00ty ef26524
Merge branch 'main' into ds3-early-banner
Br00ty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be conditional on MISC locations being randomized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not dealing with anything other than the Banner for this PR. this PR's intentions were not to go any deeper than to solve one singular issue, and that is having a Sphere 1 banner across worlds.
I'd say if thats something that you would like to see when you start implementing your take on the client, that would be the time to create a seperate PR along with your changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean for the banner specifically—since the banner location is only randomized at all if
enable_misc_locations
is set, you'll be requesting early assignment for an item that's not in the item pool at all when it's not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got what you mean now, corrected it to be under KEY locations, as that is where the banner resides, is under KEYS not MISC