DS3: Added 'Early Banner' Setting #2199
Conversation
|
tagging @Marechal-L so they can not only see it, but give a thumbs up if this is fine with them. |
ThePhar
added
the
is: enhancement
|
@Marechal-L if you agree with these changes, would you give it an approval? |
|
Sphere 1 can be very large in some games—would it make sense for this setting to also force the banner to appear in DS3 itself? |
worlds/dark_souls_3/__init__.py
Outdated
| @@ -93,6 +93,8 @@ def generate_early(self): | |||
| self.enabled_location_categories.add(DS3LocationCategory.HEALTH) | |||
| if self.multiworld.enable_progressive_locations[self.player] == Toggle.option_true: | |||
| self.enabled_location_categories.add(DS3LocationCategory.PROGRESSIVE_ITEM) | |||
| if self.multiworld.early_banner[self.player] == Toggle.option_true: | |||
There was a problem hiding this comment.
Should this be conditional on MISC locations being randomized?
There was a problem hiding this comment.
i'm not dealing with anything other than the Banner for this PR. this PR's intentions were not to go any deeper than to solve one singular issue, and that is having a Sphere 1 banner across worlds.
I'd say if thats something that you would like to see when you start implementing your take on the client, that would be the time to create a seperate PR along with your changes.
There was a problem hiding this comment.
I mean for the banner specifically—since the banner location is only randomized at all if enable_misc_locations is set, you'll be requesting early assignment for an item that's not in the item pool at all when it's not.
There was a problem hiding this comment.
I got what you mean now, corrected it to be under KEY locations, as that is where the banner resides, is under KEYS not MISC
That can be done by the player already using plando settings, or just forcing there Banner to be local via YAML. that is not the goal of this PR |
|
Users could also use plando to force the banner into sphere 1, right? It seems to me that if we're creating a more user-friendly option to effectively say "don't BK me on Small Lothric Banner", it would make sense to guarantee that the banner is in the DS3 notion of "the early game" rather than lost in the overworld of some huge game. |
|
@nex3 people would plando their Banner into sphere 1 of THEIR world. that is not the intention of this. this is what i talked about in the mod group with Zunawe, Marech, and myself. This was also already discussed in the Async i ran at the beginning of the latest ap update. there are plenty of games with big sphere 1’s and it’s more enjoyable to have items randomized throughout worlds than to have it always be in your world. if the user wants it in there world, they can specify that in there YAML already. |
|
Okay, to accommodate @nex3 request, I have changed the setting around to make it so the user can now choose whether the Small Lothric Banner is placed in an early sphere in their world, or across all worlds. |
change settings to use 'global' and 'local'
changed anywhere/self to global/local
|
just changed some words around to use global/local instead to match other games that use similar |
change to an elif Co-authored-by: Zach Parks <[email protected]>
|
@ThePhar i commited the change you requested |
Co-authored-by: Zach Parks <[email protected]>
What is this fixing or adding?
This adds a new setting called "Early Small Lothric Banner". This was inspired by the SM setting "Early Morphball" to help get people out of BK mode faster in DS3. When enabled, the lothric banner will be placed in an early sphere (sphere 1).
How was this tested?
Generated a bunch of seeds with multiple games, with the setting toggled "on" and "off" to make sure that the banner really did show up in Sphere 1 when enabled. Played a bit of a seed just to get the banner.
If this makes graphical changes, please attach screenshots.