Witness: "Fix" one of the hints not being a Haiku (seriously) #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope this gets a prize for "Most irrelevant PR in AP history" Explanation: When changing the hint system on the client side to be able to auto-wrap, decisions were made about which line breaks were still explicitly important, with most of them being removed. This hint was somewhat devalued in the process. -. --- - .... .. -. --. translates to "Nothing", which I thought was the entirety of the joke. However, the line breaks were actually also important, because: dash dot, dash dash dash, dash, dot dot dot dot, dot dot, dash dot, dash dash dot is a Haiku! And the hint's creator (oddGarrett I believe) said this was specifically part of the creative vision for this joke hint. They said it's fine, I don't need to change it, but I couldn't let that stand. So, the explicit line breaks for this joke hint are back.
NewSoupVi
changed the title
|
This better not show up in the patch notes btw Berserker I swear to god |
Berserker66
approved these changes
Aug 29, 2023
ThePhar
added
the
is: bug/fix
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…agoMW#2123) I hope this gets a prize for "Most irrelevant PR in AP history" Explanation: When changing the hint system on the client side to be able to auto-wrap, decisions were made about which line breaks were still explicitly important, with most of them being removed. This hint was somewhat devalued in the process. -. --- - .... .. -. --. translates to "Nothing", which I thought was the entirety of the joke. However, the line breaks were actually also important, because: dash dot, dash dash dash, dash, dot dot dot dot, dot dot, dash dot, dash dash dot is a Haiku! And the hint's creator (oddGarrett I believe) said this was specifically part of the creative vision for this joke hint. They said it's fine, I don't need to change it, but I couldn't let that stand. So, the explicit line breaks for this joke hint are back.
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…agoMW#2123) I hope this gets a prize for "Most irrelevant PR in AP history" Explanation: When changing the hint system on the client side to be able to auto-wrap, decisions were made about which line breaks were still explicitly important, with most of them being removed. This hint was somewhat devalued in the process. -. --- - .... .. -. --. translates to "Nothing", which I thought was the entirety of the joke. However, the line breaks were actually also important, because: dash dot, dash dash dash, dash, dot dot dot dot, dot dot, dash dot, dash dash dot is a Haiku! And the hint's creator (oddGarrett I believe) said this was specifically part of the creative vision for this joke hint. They said it's fine, I don't need to change it, but I couldn't let that stand. So, the explicit line breaks for this joke hint are back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this gets a prize for "Most irrelevant PR in AP history"
Explanation:
Witness has joke hints that were submitted by community members.
When changing the hint system on the client side to be able to auto-wrap, decisions were made about which line breaks in joke hints were still explicitly important, with most of them being removed.
The hint that is subject of this PR was somewhat devalued in the process.
-. --- - .... .. -. --. translates to "Nothing", which I thought was the entirety of the joke.
However, the line breaks were actually also important, because:
dash dot, dash dash dash,
dash, dot dot dot dot, dot dot,
dash dot, dash dash dot
is a Haiku! And the hint's creator (oddGarrett I believe) said this was specifically part of the creative vision for this joke hint. They said it's fine, I don't need to change it, but I couldn't let that stand.
So, the explicit line breaks for this joke hint are back.