Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Small typo and proofreading edits #2078

Merged
merged 16 commits into from
Sep 10, 2023
Merged

Docs: Small typo and proofreading edits #2078

merged 16 commits into from
Sep 10, 2023

Conversation

nicholassaylor
Copy link
Contributor

@nicholassaylor nicholassaylor commented Aug 3, 2023 •
edited
Loading

What is this fixing or adding?

Modifying game and set-up pages for typos, confusing/redundant sentences, and clarity.
No information was removed from these pages, and in some cases, clarifying information was added.

How was this tested?

Looking at rendered markdown

@nicholassaylor
Slight rewording of DS3 game page
e731dbf 
Lists made more concise, space added between "generated weapons" and open parenthesis
@nicholassaylor
Proofread Final Fantasy pages
74d9b19 
Fixed minor typos and reworded sentences for conciseness.
@nicholassaylor
Edited Kingdom Hearts 2 Game Page
e1c3bf0 
Refined style, capitalization, and sentence structure for clarity
@nicholassaylor
Fixed nested list in Minecraft game page
c0a055d 
Each nest needed an additional 2 spaces
@nicholassaylor
Edited Risk of Rain 2 Game Page
0ece36f 
Made various edits to redundancy within the page as well as omitted/unclear information
@nicholassaylor
Edited Stardew Valley game page
cadd04a 
Small capitalization consistency edits and slight rewording for conciseness
Silvris
Silvris suggested changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@Silvris Silvris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a couple of nitpicks. The maintainers for Final Fantasy, KH2, and RoR2 should probably sign off on this before it gets merged, as these contained larger edits.

worlds/ff1/docs/multiworld_en.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
worlds/kh2/docs/en_Kingdom Hearts 2.md Outdated Show resolved Hide resolved
@nicholassaylor nicholassaylor requested a review from Silvris August 3, 2023 14:43
@ThePhar ThePhar added the is: documentation Improvements or additions to documentation. label Aug 16, 2023
@ThePhar
Copy link
Member

ThePhar commented Aug 16, 2023 •
edited by KonoTyran
Loading

Pinging code owners for worlds touched to review.

agilbert1412
agilbert1412 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I validated the Stardew Valley changes only

kindasneaki
kindasneaki suggested changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@kindasneaki kindasneaki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs to fix the one change, and then it looks good to me

worlds/ror2/docs/en_Risk of Rain 2.md Outdated Show resolved Hide resolved
jtoyoda
jtoyoda approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@jtoyoda jtoyoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for FF1

@JaredWeakStrike
Copy link
Collaborator

The KH2 changes look good and I approve

@KonoTyran
Copy link
Contributor

@Marechal-L last ok we need to merge this.

@Silvris Silvris mentioned this pull request Aug 28, 2023
Closed
@black-sliver
Copy link
Member

@Br00ty or @Zunawe please check and approve/reject DS3

Zunawe
Zunawe approved these changes Sep 9, 2023
View reviewed changes
Copy link
Collaborator

@Zunawe Zunawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes are fine. As mentioned in Discord, the page could use a rewrite to better reflect the recent changes. I'll open a PR in a minute for that.

black-sliver
black-sliver approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we got approvals from all involved games.

@black-sliver black-sliver merged commit a1418cc into ArchipelagoMW:main Sep 10, 2023
@nicholassaylor nicholassaylor deleted the typo-fix branch September 10, 2023 01:32
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
@nicholassaylor @Silvris
@kindasneaki @FlySniper
Docs: Small typo and proofreading edits (ArchipelagoMW#2078)
4430f73 
* Slight rewording of DS3 game page

Lists made more concise, space added between "generated weapons" and open parenthesis

* Proofread Final Fantasy pages

Fixed minor typos and reworded sentences for conciseness.

* Edited Kingdom Hearts 2 Game Page

Refined style, capitalization, and sentence structure for clarity

* Fixed nested list in Minecraft game page

Each nest needed an additional 2 spaces

* Edited Risk of Rain 2 Game Page

Made various edits to redundancy within the page as well as omitted/unclear information

* Edited Stardew Valley game page

Small capitalization consistency edits and slight rewording for conciseness

* Update worlds/ff1/docs/multiworld_en.md

Co-authored-by: Silvris <[email protected]>

* Update worlds/kh2/docs/en_Kingdom Hearts 2.md

Co-authored-by: Silvris <[email protected]>

* Update worlds/kh2/docs/en_Kingdom Hearts 2.md

Co-authored-by: Silvris <[email protected]>

* Add information for EXP multiplier

Include Drive Forms and Summons

* Correction for Newt Altars RoR2

Co-Authored-By: kindasneaki <[email protected]>

---------

Co-authored-by: Silvris <[email protected]>
Co-authored-by: kindasneaki <[email protected]>
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@nicholassaylor @Silvris
@kindasneaki @Jouramie
Docs: Small typo and proofreading edits (ArchipelagoMW#2078)
93e4714 
* Slight rewording of DS3 game page

Lists made more concise, space added between "generated weapons" and open parenthesis

* Proofread Final Fantasy pages

Fixed minor typos and reworded sentences for conciseness.

* Edited Kingdom Hearts 2 Game Page

Refined style, capitalization, and sentence structure for clarity

* Fixed nested list in Minecraft game page

Each nest needed an additional 2 spaces

* Edited Risk of Rain 2 Game Page

Made various edits to redundancy within the page as well as omitted/unclear information

* Edited Stardew Valley game page

Small capitalization consistency edits and slight rewording for conciseness

* Update worlds/ff1/docs/multiworld_en.md

Co-authored-by: Silvris <[email protected]>

* Update worlds/kh2/docs/en_Kingdom Hearts 2.md

Co-authored-by: Silvris <[email protected]>

* Update worlds/kh2/docs/en_Kingdom Hearts 2.md

Co-authored-by: Silvris <[email protected]>

* Add information for EXP multiplier

Include Drive Forms and Summons

* Correction for Newt Altars RoR2

Co-Authored-By: kindasneaki <[email protected]>

---------

Co-authored-by: Silvris <[email protected]>
Co-authored-by: kindasneaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

@jtoyoda jtoyoda jtoyoda approved these changes

@Zunawe Zunawe Zunawe approved these changes

@kindasneaki kindasneaki kindasneaki approved these changes

@agilbert1412 agilbert1412 agilbert1412 approved these changes

@KonoTyran KonoTyran Awaiting requested review from KonoTyran

@Silvris Silvris Awaiting requested review from Silvris

Assignees
No one assigned
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@nicholassaylor @ThePhar @JaredWeakStrike @KonoTyran @black-sliver @agilbert1412 @kindasneaki @Zunawe @jtoyoda @Silvris