-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timespinner: many new stuffs #1433
Timespinner: many new stuffs #1433
Conversation
Now consider warp beacons as starter progression items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than a random change I don't understand. Would be nice if you added some tests for the new logic stuff -hint hint-
I am not sure why, i guess this is just to make adding future games less conflicting? Co-authored-by: Fabian Dill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracker requires #1453 but seems to work fine with it.
Found a couple of typos and some inconsistencies. I don't really care where you put your braces and brackets and white spaces, but it should be consistent.
Also please make sure the changes in WebHostLib match the corresponding sections from style.md. (You added a lot of spaces in front of {
in the css)
(Looks like #1034 will pass after merging this)
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
|
Tracker is currently broken on main, not your fault, so when you merged main, it broke on your branch as well. Just wanted to point that out if anyone else wants to test. |
* Timespinner: added RisingTides and DadPercent flags * Implemented logic for DadPercent and RisingTides * Fixed TODO's * Logic fixes * Fixed + removed LogicMixins * Fixes * More Fixes * Added UnchainedKeys flag * Fixed available items in pool with UnchainedKeys * Fixed typing callable * Fixed generation failures * More refactorings * Implemented traps * Fixed more typo * Fixed copy paste bug * Fixed teleporter logic * Fixed traps from pool * Fixed pyramid gates bug that causes a crash on connecting * Fixed seed reproduceability * Fixed logic eye for eye spy Now consider warp beacons as starter progression items * Attempt to add tracker icons using table * Replaced table layout with css grid * Fixed tracker + added Timespinner was apworld capatible * Updated archipelago items description * updated URL * Cleared up text * Fixed based on self review of PR * Fixed unit tests * Fixed seed reproduceability when the traps yaml option is not provided * Fixed logic for flooded basement * Implemented Beserkers review result I am not sure why, i guess this is just to make adding future games less conflicting? Co-authored-by: Fabian Dill <[email protected]> * Added two new options (thanks to WeffJebster) * Apply suggestions from code review Co-authored-by: black-sliver <[email protected]> * Apply suggestions from code review Co-authored-by: black-sliver <[email protected]> * Apply suggestions from code review Co-authored-by: black-sliver <[email protected]> * Apply suggestions from code review Co-authored-by: black-sliver <[email protected]> * Addition review results --------- Co-authored-by: Fabian Dill <[email protected]> Co-authored-by: black-sliver <[email protected]>
What is this fixing or adding?
(Only listing the AP changes here, not client changes)
New Flags:
Bug Fixes:
New Yaml options:
How was this tested?
Using AP world available in the timespinner channel in discord channel for the last two weeks
Also many generation tests, to find generation issues
Tracker changes where tested through a local webhost only
(the client side of the changes where tested and developed over past two months as a beta)