Tests: check that Regions are reachable #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try to prevent errors from unconnected/never reachable Regions
Berserker66
force-pushed
the
test_region_access
branch
from
b8944a9 to
e0d794c
Compare
* Tests: note oot's default unreachable regions
* [SM] Fixed failing testAllStateCanReachEverything - by adding exclusion for Regions used only when corresponding Starting Location is used - by removing unnecessary VARIA Regions used only for EscapeRando (not supported in AP anyway) * Update worlds/sm/Regions.py Co-authored-by: black-sliver <[email protected]> * Update worlds/sm/Rules.py Co-authored-by: black-sliver <[email protected]> * Update worlds/sm/Regions.py Co-authored-by: black-sliver <[email protected]> Co-authored-by: black-sliver <[email protected]>
|
As of latest, I believe SA2 should be compatible with these new unit tests. If we introduced new failures with our new content, I'll adjust. |
I'll see to adjusting SMW this weekend. |
|
i though we where just going to exclude Timespinner, since its correct with all items collected. depending on your flags entire regions will still be locked off |
|
Timespinners issues should be resolved in #1433 |
black-sliver
approved these changes
Feb 19, 2023
kindasneaki
pushed a commit
to kindasneaki/Archipelago
that referenced
this pull request
Jun 28, 2023
* Tests: check that Regions are reachable try to prevent errors from unconnected/never reachable Regions * Test region access (ArchipelagoMW#1039) * Tests: note oot's default unreachable regions * [SM] Fixed failing testAllStateCanReachEverything (ArchipelagoMW#1087) * [SM] Fixed failing testAllStateCanReachEverything - by adding exclusion for Regions used only when corresponding Starting Location is used - by removing unnecessary VARIA Regions used only for EscapeRando (not supported in AP anyway) * Update worlds/sm/Regions.py Co-authored-by: black-sliver <[email protected]> * Update worlds/sm/Rules.py Co-authored-by: black-sliver <[email protected]> * Update worlds/sm/Regions.py Co-authored-by: black-sliver <[email protected]> Co-authored-by: black-sliver <[email protected]> * Update test/general/TestReachability.py --------- Co-authored-by: espeon65536 <[email protected]> Co-authored-by: lordlou <[email protected]> Co-authored-by: black-sliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to prevent errors from unconnected/never reachable Regions
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
So, not 100% on if we should actually do this, but at least @PoryGone has indicated it might have saved them some time if this existed. It checks that all Regions are reachable by all-state, with an explicit exclusion list.
How was this tested?
running it
If this makes graphical changes, please attach screenshots.