-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new translation setup in french #1410
Conversation
@KonoTyran and @espeon65536 |
I do not understand French, but I am suspicious of the translation quality because the example YAML provided in the OoT tutorial (which needs to be gotten rid of anyway, tbh) is also translated into French. This will obviously not work for generation, which a human translating should recognize; this makes me suspect the entire thing was done by machine translation. |
I did use translation software but I reformulated the sentences that had no no or badly translated while keeping the information |
So I just finished making the necessary changes for the example in the YAML for OOT |
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Fix treu to true
@Marechal-L merci pour tes correction |
I suggest to make this one last change to make it mergeable. |
Co-authored-by: Marech <[email protected]>
to welcome and update my git for to make it mergeable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't speak french, but I believe all requested changes were made and two people read it.
If something is or becomes horribly wrong or outdated content-wise, we'll hopefully get a bug report for it.
The only thing that is missing now is adding it to the worlds' tutorials
here and here (scroll up a bit to see what espanol does and copy that).
I made the changes that you required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found two formatting issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* add new translation * Add translation for OOT Setup in french * Update setup_fr.md * Update worlds/oot/docs/setup_fr.md Co-authored-by: Ludovic Marechal <[email protected]> * Update setup_fr.md Fix treu to true * Update worlds/oot/docs/setup_fr.md Co-authored-by: Marech <[email protected]> * Update OOT Init and Update Minecraft Init * Fix formatting errors --------- Co-authored-by: Ludovic Marechal <[email protected]> Co-authored-by: black-sliver <[email protected]>
* add new translation * Add translation for OOT Setup in french * Update setup_fr.md * Update worlds/oot/docs/setup_fr.md Co-authored-by: Ludovic Marechal <[email protected]> * Update setup_fr.md Fix treu to true * Update worlds/oot/docs/setup_fr.md Co-authored-by: Marech <[email protected]> * Update OOT Init and Update Minecraft Init * Fix formatting errors --------- Co-authored-by: Ludovic Marechal <[email protected]> Co-authored-by: black-sliver <[email protected]>
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
Adding new translation for minecraft setup in french and OOT setup in french
How was this tested?
in local web server
If this makes graphical changes, please attach screenshots.
no graphical changes