Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new translation setup in french #1410

Merged
merged 43 commits into from
Feb 27, 2023
Merged

Conversation

TheLynk
Copy link
Contributor

@TheLynk TheLynk commented Jan 24, 2023

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

Adding new translation for minecraft setup in french and OOT setup in french

How was this tested?

in local web server

If this makes graphical changes, please attach screenshots.

no graphical changes

@Berserker66
Copy link
Member

@KonoTyran and @espeon65536
My recommendation for review is to run it back to english through a translation and see if it looks at least mostly ok. Unless one of you is capable of French of course.

@espeon65536
Copy link
Collaborator

I do not understand French, but I am suspicious of the translation quality because the example YAML provided in the OoT tutorial (which needs to be gotten rid of anyway, tbh) is also translated into French. This will obviously not work for generation, which a human translating should recognize; this makes me suspect the entire thing was done by machine translation.

@TheLynk
Copy link
Contributor Author

TheLynk commented Jan 27, 2023

I did use translation software but I reformulated the sentences that had no no or badly translated while keeping the information
afterwards it is possible that I missed some line in the explanation in the example of the YAML but otherwise for the rest I am sure of what I wrote
So I looked a little closer and I saw the problem I'm putting all the variables back in English but leaving the notes in French

@TheLynk TheLynk changed the title add new translation for minecraft setup in french add new translation setup in french Jan 27, 2023
@TheLynk
Copy link
Contributor Author

TheLynk commented Jan 27, 2023

So I just finished making the necessary changes for the example in the YAML for OOT

worlds/minecraft/docs/minecraft_fr.md Outdated Show resolved Hide resolved
worlds/minecraft/docs/minecraft_fr.md Outdated Show resolved Hide resolved
worlds/minecraft/docs/minecraft_fr.md Outdated Show resolved Hide resolved
worlds/minecraft/docs/minecraft_fr.md Outdated Show resolved Hide resolved
worlds/minecraft/docs/minecraft_fr.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_fr.md Outdated Show resolved Hide resolved
TheLynk and others added 9 commits February 15, 2023 04:18
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: Ludovic Marechal <[email protected]>
Fix treu to true
@TheLynk
Copy link
Contributor Author

TheLynk commented Feb 15, 2023

@Marechal-L merci pour tes correction

@Marechal-L
Copy link
Collaborator

I suggest to make this one last change to make it mergeable.
Thanks from the French players community :)

@TheLynk
Copy link
Contributor Author

TheLynk commented Feb 21, 2023

I suggest to make this one last change to make it mergeable. Thanks from the French players community :)

to welcome and update my git for to make it mergeable

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak french, but I believe all requested changes were made and two people read it.

If something is or becomes horribly wrong or outdated content-wise, we'll hopefully get a bug report for it.

The only thing that is missing now is adding it to the worlds' tutorials
here and here (scroll up a bit to see what espanol does and copy that).

@TheLynk
Copy link
Contributor Author

TheLynk commented Feb 24, 2023

I made the changes that you required

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two formatting issues

worlds/minecraft/docs/minecraft_fr.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_fr.md Outdated Show resolved Hide resolved
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@black-sliver black-sliver merged commit 79b8733 into ArchipelagoMW:main Feb 27, 2023
kindasneaki pushed a commit to kindasneaki/Archipelago that referenced this pull request Jun 28, 2023
* add new translation

* Add translation for OOT Setup in french

* Update setup_fr.md

* Update worlds/oot/docs/setup_fr.md

Co-authored-by: Ludovic Marechal <[email protected]>

* Update setup_fr.md

Fix treu to true

* Update worlds/oot/docs/setup_fr.md

Co-authored-by: Marech <[email protected]>

* Update OOT Init and Update Minecraft Init

* Fix formatting errors

---------

Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: black-sliver <[email protected]>
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
* add new translation

* Add translation for OOT Setup in french

* Update setup_fr.md

* Update worlds/oot/docs/setup_fr.md

Co-authored-by: Ludovic Marechal <[email protected]>

* Update setup_fr.md

Fix treu to true

* Update worlds/oot/docs/setup_fr.md

Co-authored-by: Marech <[email protected]>

* Update OOT Init and Update Minecraft Init

* Fix formatting errors

---------

Co-authored-by: Ludovic Marechal <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants