Vehicle auto refuel (part 2)

[LovelySanta]

Continuance from #464 taken before @kingarthur91 rebased from dev@f22bea2

This PR is forked at 0f20991, where the last commit was done before the rebase happened...

[LovelySanta]

PR updated to the latest state of #464:

• Pulled latest changes from dev@c31c2c3
• Committed changes from @Pezzawinkle's Vehicle auto refuel #464 (review):
  • Vehicle auto refuel #464 (review)
  • Vehicle auto refuel #464 (review)

[LovelySanta]

Closed #464 as this is now the cleaned up version of #464@47aad63

[LovelySanta]

As a follow up on @Pezzawinkle's #464 (review) comment:

I'm not sure if we want to increase the tick count a bit higher but im fine with it now.
The thing to consider, is realistically, how many "stacks" of wood do we want to stick in per second?

My suggestion would be more like this:

1. Have a new equipment, named Burner Refueler (which could consume a small amount of power)
2. Instead of iterating through each vehicle burner, I would iterate over each refueler, where every refueler:
   • Attempt at filling each burner generating equipment in that equipment grid
   • Stop filling equipment if:
     • All the equipment is full of fuel (can't insert anymore)
     • Has no more fuel to insert (inventory out of fuel)
     • Has inserted more than X amount of KJ worth of energy (this can be coded)
     • Has insufficient energy to insert more fuel (see next bullet)
   • This 'laser' equipment (with 0 range) will have a buffer that we can drain for energy:
     • By base game, steady drain for 'idling'
     • By code, taking a bit of energy for each insert action (measured in KJ/item)
3. Depending on the how much items/s we want to auto insert (this can be a low number), we can tweak how much ticks pass between attempts
4. Player can speed up the filling process by adding more Refuel equipments in a certain equipment grid. Because insertion is measured in items/s, more refuelers are needed for wood compared to higher fuel yielding items.

The code that is here already is the major part of the work, this only requires small tweaks (and addition of a new equipment item) in order to work. This would also resolve incompatibilities with existing vehicle(burners) in existing savegames...

[Pezzawinkle]

From testing it was not moving single items, rather full stacks, but that may have just been doing all 600 transitions in the same tick (in the case of carbon).
I really like the idea of a refilling item, but at the same time it is functional and unless you have a substantial amount of crawlers running around, I don't see it being a major issue, was just a hypothetical.

[kingarthur91]

From testing it was not moving single items, rather full stacks, but that may have just been doing all 600 transitions in the same tick (in the case of carbon).

it is not. it checks for how much it can insert and then removes that amount and then inserts that amount or max items available which ever one is less.

it is functional currently but i could see adding the fueler equipment as a decent option as then we dont need to care about tracking the generators and only keep track of the fueler equipment which would simplify mod compatibility. i know the og version wasn't setup at all for mod compatibility and wont even work with bobs equipment.

[LovelySanta]

When both reviewees approve of the current state of #577 compared to #464, branch vehicle-auto-refuel can be removed. (Please review with comment instead of approved.)