Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingredient count issue with ore-sorting-4 #514

Closed
DustinKlein opened this issue Jan 4, 2021 · 6 comments
Closed

Ingredient count issue with ore-sorting-4 #514

DustinKlein opened this issue Jan 4, 2021 · 6 comments
Labels
Impact: Mod compatibility Mainly involves 3rd party mods

Comments

@DustinKlein
Copy link

DustinKlein commented Jan 4, 2021

Describe the bug
The ore-sorting-facility-4 has the same "ingredient_count" as facility 3 which is 6. Some Mods like "EAB" use 7 ingredients which cannot be produced even with the highest facility.

Additional context
I would like to ask if the ingredient_count is intended to be 6 at the max or if you could change it to a higher value.
Thanks a lot for all of your work.

@Pezzawinkle
Copy link
Collaborator

Just for some clarity, which mod is "EAB"... i know for a fact that none of clowns extended sorting recipes contain more than 6.
if a mod adds a recipe which cannot be crafted, the mod which adds the recipe should also be changing the crafting limits, which is quite easy...

@DustinKlein
Copy link
Author

Thank you for the superfast answer. The mod i had in mind was "Expanded AngelBob" it is using 7 ingredients for platinum sorting. Sadly this mod's editor is not as convenient to contact as you with this git. Iam totally on your side, the other mod should adjust the settings. I was hoping that maybe it was not intended to be like this so i get around manually re-coding the mods for my server and every person joining.

So if you do not intend to update the code would you mind to give me the line of code which changes the crafting limit for ore-sorting-facility-4? So i can try my best to reach the other author or keep my changes as clean as possible in an own mod.

@Pezzawinkle
Copy link
Collaborator

Pezzawinkle commented Jan 4, 2021

The author is SuperSandro2000, he is an active member of the angels discord:
https://discord.gg/ftq8Yrf6
I can do some tests and ask him for some assistance on the matter if you wish.

@DustinKlein
Copy link
Author

This would be very kind of you. Thanks alot for your help.

@SuperSandro2000
Copy link

The author is SuperSandro21000, he is an active member of the angels discord:
discord.gg/ftq8Yrf6
I can do some tests and ask him for some assistance on the matter if you wish.

*2000

EAB is WIP and I am currently not planning to develop it as long as I don't need the better assembly machines.

@Pezzawinkle Pezzawinkle added Impact: Mod compatibility Mainly involves 3rd party mods Status: Wont Fix Works as intended labels Jan 13, 2021
@LovelySanta
Copy link
Collaborator

We could just set the last tier to not have a limit, this will also make sure that ANY mod has at least one machine that can craft it....

@Pezzawinkle Pezzawinkle removed the Status: Wont Fix Works as intended label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Mod compatibility Mainly involves 3rd party mods
Projects
None yet
Development

No branches or pull requests

4 participants