Conversation
Add missing coverage highlighted by #2512. - Add missing coverage. - Remove redundant code paths. - Avoid allocating delegates. - Fix file name casing.
martincostello
added
enhancement
CI/build
.NET
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (6)
- src/Polly/Registry/PolicyRegistry.cs: Evaluated as low risk
- test/Polly.Extensions.Tests/DependencyInjection/PollyServiceCollectionExtensionTests.cs: Evaluated as low risk
- test/Polly.Extensions.Tests/Registry/ConfigureBuilderContextExtensionsTests.cs: Evaluated as low risk
- test/Polly.Extensions.Tests/Telemetry/TelemetryOptionsTests.cs: Evaluated as low risk
- test/Polly.Extensions.Tests/Telemetry/TelemetryResiliencePipelineBuilderExtensionsTests.cs: Evaluated as low risk
- src/Polly/Caching/CacheSyntax.cs: Evaluated as low risk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2514 +/- ##
==========================================
+ Coverage 94.09% 94.22% +0.13%
==========================================
Files 311 311
Lines 7431 7413 -18
Branches 1043 1038 -5
==========================================
- Hits 6992 6985 -7
+ Misses 342 335 -7
+ Partials 97 93 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| return services; | ||
| } | ||
|
|
||
| services.AddOptions(); |
There was a problem hiding this comment.
The call to AddOptions<T>() on Line 258 does this under-the-hood.
There was a problem hiding this comment.
The explicit interface implementations were just exact duplicates of the other implementations.
| _registry = registry; | ||
| } | ||
|
|
||
| private ConcurrentDictionary<string, IsPolicy> ThrowIfNotConcurrentImplementation() |
There was a problem hiding this comment.
This is redundant if we just enforce that the test constructor creates a concurrent dictionary.
Add coverage highlighted as missing from the patch.
1 participant
Add missing coverage highlighted by #2512.