Skip to content

Remove ignored mutations#2512

Closed
martincostello wants to merge 1 commit intomainfrom
remove-ignored-mutations
Closed

Remove ignored mutations#2512
martincostello wants to merge 1 commit intomainfrom
remove-ignored-mutations

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Feb 19, 2025

Just curious as to the impact on the mutation tests if we remove this, as Polly.Testing has to manually remove it to get any results at all anyway:

Polly/build.cake

Lines 315 to 318 in 4469d83

if (moduleName == "Polly.Testing")
{
strykerConfigPath = PatchStrykerConfig(strykerConfigPath, (config) => config.Remove("ignore-mutations"));
}

Just curious as to the impact on the mutation tests if we remove this.
@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.09%. Comparing base (4469d83) to head (94f64c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2512   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files         311      311           
  Lines        7431     7431           
  Branches     1043     1043           
=======================================
  Hits         6992     6992           
  Misses        342      342           
  Partials       97       97           
Flag Coverage Δ
linux 94.09% <ø> (ø)
macos 94.09% <ø> (ø)
windows 94.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

martincostello added a commit that referenced this pull request Feb 19, 2025
Add missing coverage highlighted by #2512.

- Add missing coverage.
- Remove redundant code paths.
- Avoid allocating delegates.
- Fix file name casing.
@martincostello
Copy link
Member Author

The coverage we lose with the current settings appear to fall mainly into these buckets:

  • Argument validation
  • Argument validation where removing it falls through to another overload that has the same checks
  • Checking that something that should have been disposed was disposed

Have opened #2514 to fix some of the coverage gaps.

@martincostello martincostello deleted the remove-ignored-mutations branch February 19, 2025 15:22
martincostello added a commit that referenced this pull request Feb 19, 2025
Add missing coverage highlighted by #2512.

- Add missing coverage.
- Remove redundant code paths.
- Avoid allocating delegates.
- Fix file name casing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant