Support for MySQL storage #5411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java
EricWittmann
previously approved these changes
Oct 28, 2024
There was a problem hiding this comment.
This looks pretty good to me! I'd like to get at least one more review before merging. @carlesarnal or @jsenko ?
|
@Yoni-Weisberg can you please run |
I though I already approved it but I just approved the CI execution. I'll wait until CI is green for the final +1. |
|
Hi @carlesarnal, I've run spotless. waiting for CI workflow again |
EricWittmann
approved these changes
Oct 28, 2024
carlesarnal
approved these changes
Oct 28, 2024
|
Nice work, thanks for the contribution @Yoni-Weisberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request for #5309