Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MySQL storage #5411

Merged
merged 12 commits into from
Oct 29, 2024
Merged

Conversation

Yoni-Weisberg
Copy link
Contributor

pull request for #5309

EricWittmann
EricWittmann previously approved these changes Oct 28, 2024
Copy link
Member

@EricWittmann EricWittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me! I'd like to get at least one more review before merging. @carlesarnal or @jsenko ?

@EricWittmann
Copy link
Member

@Yoni-Weisberg can you please run mvn spotless:apply and then commit the resulting changes?

@carlesarnal
Copy link
Member

@Yoni-Weisberg can you please run mvn spotless:apply and then commit the resulting changes?

This looks pretty good to me! I'd like to get at least one more review before merging. @carlesarnal or @jsenko ?

I though I already approved it but I just approved the CI execution. I'll wait until CI is green for the final +1.

@Yoni-Weisberg
Copy link
Contributor Author

Hi @carlesarnal, I've run spotless. waiting for CI workflow again

@EricWittmann EricWittmann merged commit 749677c into Apicurio:main Oct 29, 2024
19 checks passed
@EricWittmann
Copy link
Member

Nice work, thanks for the contribution @Yoni-Weisberg

@Yoni-Weisberg Yoni-Weisberg deleted the feat/mysql-support branch October 29, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants