Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MySQL storage #5309

Open
Yoni-Weisberg opened this issue Oct 7, 2024 · 5 comments
Open

Support for MySQL storage #5309

Yoni-Weisberg opened this issue Oct 7, 2024 · 5 comments

Comments

@Yoni-Weisberg
Copy link
Contributor

Feature or Problem Description

Implementing MySQL as an SQL storage option

Proposed Solution

I can create the necessary classes, but I’ll need your assistance, particularly with testing.

Additional Context

I noticed that this has already been suggested here, but there hasn't been any progress on it.

@EricWittmann
Copy link
Member

This will be great. And it would not be very difficult. Happy to help!

If you want, we can start with a dedicated branch for the work. I don't think we need any new tests. We just need to run existing tests against the MySQL database.

@Yoni-Weisberg
Copy link
Contributor Author

Yoni-Weisberg commented Oct 9, 2024

Hi. thanks for the quick response.

I've already started to to work on this locally, so let me know the way you want to create the branch.

Regarding tests:

  1. How can I run the integration test specifying mysql as storage?
  2. I see AbstractRegistryStorageTest tests are commented out - how should I run unit-tests against MySQL storage

@Yoni-Weisberg
Copy link
Contributor Author

Hi @EricWittmann, I think I am done, please let me know the process of creating new branch, so I can push my changes.

@EricWittmann
Copy link
Member

Hey @Yoni-Weisberg that's great! You should be able to just open a Pull Request against the main branch. The project README should have information about that.

Also, we very recently re-enabled the SQL test. So that should actually help you a lot I think. You should be able to create a new variant of that test very easily. Use this for inspiration:

https://github.com/Apicurio/apicurio-registry/blob/main/app/src/test/java/io/apicurio/registry/storage/impl/sql/PostgresqlStorageTest.java

@Yoni-Weisberg
Copy link
Contributor Author

Hi @EricWittmann, I've opened a PR: #5411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants