-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MySQL storage #5309
Comments
This will be great. And it would not be very difficult. Happy to help! If you want, we can start with a dedicated branch for the work. I don't think we need any new tests. We just need to run existing tests against the MySQL database. |
Hi. thanks for the quick response. I've already started to to work on this locally, so let me know the way you want to create the branch. Regarding tests:
|
Hi @EricWittmann, I think I am done, please let me know the process of creating new branch, so I can push my changes. |
Hey @Yoni-Weisberg that's great! You should be able to just open a Pull Request against the Also, we very recently re-enabled the SQL test. So that should actually help you a lot I think. You should be able to create a new variant of that test very easily. Use this for inspiration: |
Hi @EricWittmann, I've opened a PR: #5411 |
Feature or Problem Description
Implementing MySQL as an SQL storage option
Proposed Solution
I can create the necessary classes, but I’ll need your assistance, particularly with testing.
Additional Context
I noticed that this has already been suggested here, but there hasn't been any progress on it.
The text was updated successfully, but these errors were encountered: