Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Does apicurio-registry-sql support mysql? #1546

Closed
Yuutakasan opened this issue Jun 8, 2021 · 5 comments
Closed

[question] Does apicurio-registry-sql support mysql? #1546

Yuutakasan opened this issue Jun 8, 2021 · 5 comments
Labels
type/enhancement New feature or request

Comments

@Yuutakasan
Copy link

I think I can handle it by changing the jdbc driver settings to mysql, but is there any way to write SQL that is not compatible with mysql?

@EricWittmann
Copy link
Member

Registry does not currently support MySQL. It would not be difficult to add support (most of the existing SQL will work fine against MySQL).

However, note that changing the driver is not enough. The way Quarkus works it that DB support is determined at build time, not at runtime. So to do this we would need another builder, where the appropriate changes are made to application.properties. We'll also need another one of these for mysql:

https://github.com/Apicurio/apicurio-registry/blob/master/app/src/main/java/io/apicurio/registry/storage/impl/sql/H2SqlStatements.java

If you track down how that is being used, you'll probably see what needs to be done. If not, I can probably get you started by making a list of changes needed. :)

@EricWittmann EricWittmann added the type/enhancement New feature or request label Jun 10, 2021
@maver1ck
Copy link

@EricWittmann provided we will write MySQL support is there a chance for merging PR ?
We're thinking about using apicurio-registry-sql with MySQL but don't want to have own fork forever.

@carlesarnal
Copy link
Member

@maver1ck contributions are always more than welcome. If you want to contribute MySQL support, the timing might be perfect, there's a PR from another community member that can give you a better sense of what we expect/what needs to be added to support a new SQL flavour. Let me know if you need help to get started or any doubts!

@maver1ck
Copy link

maver1ck commented Dec 1, 2022

Great. I will wait until another PR is merged.

@EricWittmann
Copy link
Member

@maver1ck The support for SQL Server has been merged and included in 2.4.0.Final. Have a look at that to get started! Let us know if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants