feat(extensions): mirror DocxReview as IDocxReview - #375
Merged
Conversation
Ank-KhoaHo
added a commit
that referenced
this pull request
Aug 24, 2026
🤖 I have created a release *beep* *boop* --- ## [0.37.0](v0.36.1...v0.37.0) (2026-08-24) ### Added * **extensions:** mirror DocxReview as IDocxReview ([#375](#375)) ([8bcfacf](8bcfacf)) ### Fixed * **ci:** remove the duplicate ignore entries that broke the Dependabot config ([#374](#374)) ([cab06a2](cab06a2)) * **core:** restore the samples to the floating version ([#371](#371)) ([51a66eb](51a66eb)) ### Changed * **deps:** bump OfficeIMO to 3.2.6, AngleSharp to 1.7.2 and PdfPig to 0.1.16 ([#366](#366)) ([df1dc03](df1dc03)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the structural lag the same day it opened.
DocxReviewreached nuget.org in 0.36.1, so theextensions package can finally wrap it — that gap has gone stale nine times, and this is the first
time it was paid in a day.
IDocxReviewandDocxReviewServicemirror all four operations 1:1,byte[]forbyte[]andStreamforStream. TheAnk.DocToolkitfloor moves to[0.36.1, ).A third guard the project split had quietly narrowed
CLAUDE.mdprescribes a 1:1 mirror check, and it readsrc/DocToolkit/{core}.cs— which after thesplit matched nothing for
DocxEditor,PdfEditor,WorkbookEditor,PresentationEditororDocxReview. Five of thirteen pairs. It is a glob now, and the new pair was added in the samechange as the interface, which is what that section requires.
That is the third:
StreamOverloadTests' inventory,check-readme-coverage.py, and now this.Tests that discriminate
Nine, each asserting something a passthrough would fail — the standard the DI suite already sets,
because these services are pure delegation and the real risk is a member wired to the wrong thing:
Inspectreads a document that has review state, so a stub returning an empty report failswhere a clean-document test would pass
RemoveCommentsis asserted to have removed themFixtures are raw OpenXml, available transitively through
Ank.DocToolkit— no new dependency.They have to be:
TrackChangesrecords nothing for the library's own edits, and there is nocomment-authoring API, so a fixture built through
DocxEditorwould assert against empty setsforever while looking green.
Verified by sabotage, not by reading
RejectRevisionswired toAcceptRevisionsInspectwired to a clean documentRemoveCommentsreturns its inputDI coverage back to 100%/100%, the floor it is held at because an uncovered member here is a
member nobody checked was wired to anything.
One number removed
The extensions README said "fifteen injectable interfaces" while listing sixteen, and seventeen are
registered — stale by two before this change touched it. The list is what
check-readme-coverage.pyverifies; the count was a claim nothing did, so it is gone rather than corrected.
Closes A66.