fix(core): restore the samples to the floating version - #371
Merged
Conversation
Ank-KhoaHo
added a commit
that referenced
this pull request
Aug 24, 2026
🤖 I have created a release *beep* *boop* --- ## [0.37.0](v0.36.1...v0.37.0) (2026-08-24) ### Added * **extensions:** mirror DocxReview as IDocxReview ([#375](#375)) ([8bcfacf](8bcfacf)) ### Fixed * **ci:** remove the duplicate ignore entries that broke the Dependabot config ([#374](#374)) ([cab06a2](cab06a2)) * **core:** restore the samples to the floating version ([#371](#371)) ([51a66eb](51a66eb)) ### Changed * **deps:** bump OfficeIMO to 3.2.6, AngleSharp to 1.7.2 and PdfPig to 0.1.16 ([#366](#366)) ([df1dc03](df1dc03)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undoes the temporary pin from the 0.36.0 packaging hotfix. All twelve samples are back on
Version="*", and the pin comment is gone from each.*is what actually caught 0.36.0 shipping a 67 KB shell — it surfaced as red CI on an unrelatedDependabot PR, before any consumer reported it. A floor resolves to the LOWEST satisfying version
instead, which is how that canary was once disarmed for weeks with no signal. Twelve pinned samples
were twelve canaries switched off.
Why the pin existed
The canary firing also blocked the repair:
release.ymlbuilds the solution before it packs, sowith
*resolving to the broken release there was no way to publish the version that fixed it.Unlisting 0.36.0 would have made
*fall back on its own, but that needs a nuget.org key andTrusted Publishing means none is stored. Pinning was the only exit reachable from the repo.
That window was about four hours.
Verified on the resolved value, not the csproj
Solution builds with 0 warnings and 0 errors; 1528 core + 137 extensions tests pass on both target
frameworks.
The 0.34.0 is correct rather than a leftover.
MinimalApireferences only the extensions package,and NuGet resolves a floor to the lowest satisfying version —
CLAUDE.mdalready records that aconsumer installing the DI package alone never gets the newest core. That sample exists to prove the
core arrives transitively at all.
Closes F11.