Add support for nowrap flags to trunc
#1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(To undraft when PR85592 lands in LLVM.) |
antoniofrighetto
force-pushed
the
feature/handle-trunc-zero-or-sign
branch
from
e905853 to
86725bc
Compare
nunoplopes
reviewed
Mar 27, 2024
ir/instr.cpp
Outdated
| if (flags & NSW) | ||
| non_poison.add(val.trunc(trunc_bits).sext(orig_bits - trunc_bits) == | ||
| val); | ||
| return {val.trunc(trunc_bits), non_poison()}; |
There was a problem hiding this comment.
I suggest don't computing trunc() 3x times by saving this in a tmp var.
These functions do pre-processing and can be expensive.
The rest of the patch is great, thanks!
There was a problem hiding this comment.
Definitely, thanks for the quick review! :)
|
fixes #1023. |
Nowrap poison-generating flags to `trunc` have been recently introduced in LLVM.
antoniofrighetto
force-pushed
the
feature/handle-trunc-zero-or-sign
branch
from
86725bc to
2504d5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowrap poison-generating flags to
trunchave been recently introduced in LLVM.