forked from facebook/winterfell
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr 2 #3
Draft
Al-Kindi-0
wants to merge
13
commits into
pr_1
Choose a base branch
from
pr_2
base: pr_1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pr 2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to be extended to the next power of two
Enlarge exemption limit
bobbinth
requested changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you! A few comments:
- I think this is not based on the latest version of the codebase which is currently in Winterfell. You should probably update your fork to the latest version and then rebase this (and the other PR) from that.
- Let's move
mds_multiply_freq()
and all associated functions/constants into a separate module - e.g.,mds_freq.rs
. I think this code deserves its own module. - Let's also have the fully defined MDS matrix exposed as a constant (this will be needed once you rebase from latest changes).
- Let's add some tests to make sure naive MDS matrix multiplication (using fully defined MDS matrix) gives the same results as the one using
mds_multiply_freq()
. These tests could also go intomds_freq.rs
file.
Thank you for the feedback!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing Rescue prime, with optimizations, in the 64bit prime field in Montgomery form.