Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge exemption limit #97

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Conversation

Nashtare
Copy link
Contributor

This (tiny) PR increases the transition constraint exemption limit in AirContext by one.

I believe that in some cases, the current limit may be a problem (for instance a trace where the 2^k rows are necessary, which then needs to be extended to the next power of two 2^{k+1}). In such cases, the current limit won't be sufficient, because the last evaluation frame to be checked on the proving side will overlap between the actual trace and the dummy values.

@Nashtare
Copy link
Contributor Author

(Clippy failing is not due to the changes induced by this PR, but I can make it go green here if needed)

@irakliyk
Copy link
Collaborator

Thank you! Looks good to me. I'll fix the clippy issue in a separate commit.

@irakliyk irakliyk self-requested a review June 18, 2022 04:13
@irakliyk irakliyk merged commit 0249cd6 into facebook:main Jun 18, 2022
@Nashtare Nashtare deleted the constraint_exemption branch August 22, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants