Skip to content

Fix root yarn.lock needing to be updated on release PRs#11962

Merged
mergify[bot] merged 1 commit intomasterfrom
mk/use-workspace-in-boot-for-fusdc-deploy
Sep 19, 2025
Merged

Fix root yarn.lock needing to be updated on release PRs#11962
mergify[bot] merged 1 commit intomasterfrom
mk/use-workspace-in-boot-for-fusdc-deploy

Conversation

@mujahidkay
Copy link
Member

@mujahidkay mujahidkay commented Sep 19, 2025

Description

On release PR after the lerna commit, we have had to update the root lockfile every time an rc PR was created. This PR addresses that by adopting the workspace protocol in packages/boot specifically for the "@aglocal/fast-usdc-deploy" package. This will allow us to enforce frozen-lockfile in the docker build step when pushing sdk tag.

Security Considerations

None that I know of.

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

CI should still pass.

Upgrade Considerations

Allows us to go back to single commit rc PRs for releases.

@mujahidkay mujahidkay self-assigned this Sep 19, 2025
@mujahidkay mujahidkay requested a review from a team as a code owner September 19, 2025 13:58
@mujahidkay
Copy link
Member Author

@Mergifyio rebase

uses workspace protocol in packages/boot for fast-usdc-deploy
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2025

rebase

✅ Branch has been successfully rebased

@mujahidkay mujahidkay force-pushed the mk/use-workspace-in-boot-for-fusdc-deploy branch from 71c0c3b to f50e020 Compare September 19, 2025 14:02
@cloudflare-workers-and-pages
Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: f50e020
Status: ✅  Deploy successful!
Preview URL: https://95e0389d.agoric-sdk.pages.dev
Branch Preview URL: https://mk-use-workspace-in-boot-for.agoric-sdk.pages.dev

View logs

@mujahidkay mujahidkay requested a review from mhofman September 19, 2025 14:36
@mhofman mhofman requested a review from turadg September 19, 2025 14:52
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would love to hear from @turadg if there was a reason this didn't use the workspace protocol in the first place in #11397, maybe just an incomplete replace all?

@turadg
Copy link
Member

turadg commented Sep 19, 2025

LGTM but would love to hear from @turadg if there was a reason this didn't use the workspace protocol in the first place in #11397, maybe just an incomplete replace all?

My guess is missed in a merge. Anyway, please do merge this.

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Sep 19, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@turadg turadg added the bypass:integration Prevent integration tests from running on PR label Sep 19, 2025
@turadg
Copy link
Member

turadg commented Sep 19, 2025

Bypassing flake test:staking

@turadg
Copy link
Member

turadg commented Sep 19, 2025

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 473e410 into master Sep 19, 2025
119 of 120 checks passed
@mergify mergify bot deleted the mk/use-workspace-in-boot-for-fusdc-deploy branch September 19, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge:rebase Automatically rebase updates, then merge bypass:integration Prevent integration tests from running on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants