Merged
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
57e542d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://81a59cf1.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-adopt-protocol.agoric-sdk.pages.dev |
samsiegart
reviewed
May 22, 2025
Contributor
samsiegart
left a comment
samsiegart
left a comment
There was a problem hiding this comment.
Cool TIL, will look into this for ui-kit. Deferring approval to @kriskowal
kriskowal
approved these changes
May 28, 2025
Member
kriskowal
left a comment
kriskowal
left a comment
There was a problem hiding this comment.
I did not find time to investigate why this does not work for xsnap. Please feel free to assign that investigation to me.
find: "@agoric/(.+)": "\^.*" replace: "@agoric/$1": "workspace:*"
npm error code EUNSUPPORTEDPROTOCOL␊ npm error Unsupported URL Type "workspace:": workspace:*␊
mergify
bot
force-pushed
the
ta/adopt-protocol
branch
from
ac318a8 to
57e542d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: #451
Description
Now that we're past Yarn 1, we can use more modern package management features like
workspace:protocol.It's also supported by NPM v7+, but for some reason xsnap install balks at it so b4d4f51 reverts it for that one package. cc @kriskowal for ideas to solve that
Security Considerations
Marginal benefit to prevent NPM fetch if a dep mismatches local version.
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Here's how I made the change:
find: "@agoric/(.+)": "^."
replace: "@agoric/$1": "workspace:"
Upgrade Considerations
n/a