Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$generichide filters not parsed on iOS [Bug] #255

Closed
gotitbro opened this issue Nov 22, 2016 · 19 comments
Closed

$generichide filters not parsed on iOS [Bug] #255

gotitbro opened this issue Nov 22, 2016 · 19 comments
Assignees

Comments

@gotitbro
Copy link

The Adguard Content Blocker for iOS does not parse filters with $generichide modifier on Safari iOS but it parses $elemhide filters.

How to reproduce?

Enable "Mobile ads filter" in Adguard (it contains @@||m.beautypageants.in^$generichide) and go to http://m.beautypageants.in/ and click on any article, you will get an adb warning which the $generichide was supposed to fix.

Now add this filter: @@||m.beautypageants.in^$elemhide to user filters and visit any article on the website again, you will not get an anti adb warning (this means $elemhide was successfully parsed but $generichide was not).

This can be tested for other sites as well. Please fix this major issue.

Note: Using Mobile Safari 10.0 on iOS 10.1.1 with Adguard 1.1.1

Alex-302 added a commit to AdguardTeam/AdguardFilters that referenced this issue Nov 23, 2016
@Alex-302
Copy link
Member

Confirmed on also Android.
Temporary added to Mobile filter

@@||m.beautypageants.in^$elemhide

Manually renamed element was hidden by generiс element hiding rule
http://ipic.su/img/img7/fs/kiss_568kb.1479904042.png
Our filters doesn't contains specific rules for this domain.
@ameshkov

@ameshkov
Copy link
Member

@Alex-302 can you reproduce it in v2.8?

@Alex-302
Copy link
Member

@ameshkov no. Seems to be works as expected.
On iOS I can read articles only with $elemhide exclusion.

@ameshkov
Copy link
Member

Got it, thank you!

Filed a bug report to extension repo (as iOS version shares rules converter with it):
AdguardTeam/AdguardBrowserExtension#437

@Stillness-2 please update converter when this bug is fixed on extension side.

@gotitbro
Copy link
Author

@ameshkov @Stillness-2 I see that this issue has been resolved with the Safari extension, any update on when this might be fixed for the iOS app, can't access a lot of websites due to this issue.

@ameshkov
Copy link
Member

iOS beta with the new converter version should be ready by the end of this week.

@gotitbro
Copy link
Author

That's great! Hope this will be pushed to stable branch as well soon.

@gotitbro
Copy link
Author

gotitbro commented Jan 9, 2017

@ameshkov The recent update for Adguard for iOS (1.1.4) does not fix this issue and also breaks the temporary fix with $elemhide.
I am unable to access sites like:

http://m.food.ndtv.com/lists/10-quick-party-snacks-720647
http://khabar.ndtv.com/news/world/explosion-rocks-syrias-aleppo-as-residents-return-1641457

More info: https://forum.adguard.com/index.php?threads/ndtv-com-anti-adb-ios.18066/#post-120384

I am left completely helpless as I can't even use the $elemhide modifier now to fix this issue, please help.

@ameshkov ameshkov added the Bug label Jan 9, 2017
@ameshkov ameshkov modified the milestones: 1.2.0 Pro, 1.2.0 Jan 9, 2017
@ameshkov
Copy link
Member

ameshkov commented Jan 9, 2017

@gotitbro weird, thanks for reporting it.

@gotitbro
Copy link
Author

@ameshkov Thanks for getting back to me here AdguardTeam/AdguardBrowserExtension#507, I just browsed through some issues and a lot of them seem to be related to this bug, lets push the update for iOS soon as well :)

@gotitbro
Copy link
Author

@ameshkov Any update on when this might be fixed? Can't access an increasing number of websites due to this bug.

@ameshkov
Copy link
Member

@gotitbro it was pushed to beta yesterday

@gotitbro
Copy link
Author

@ameshkov That's good to know, can you tell me how to join the beta?

@vityevato
Copy link
Member

#316

@ameshkov
Copy link
Member

@gotitbro
Copy link
Author

gotitbro commented Jan 26, 2017

@ameshkov Thanks for the link, I have some questions about TestFlight:
If I am using a beta version of an app through TestFlight and an update is published on the App Store will I be able to update to the stable version (if yes do the updates come through App Store or TestFlight) or I will stay on the current beta version until the next beta is pushed?

@vbagirov
Copy link
Member

@gotitbro as far as I know, no, you will not be able to. Only test builds appear in TestFlight, and if there are none, you won't be able to use Adguard (unless you have a purchased Pro version or a free version from AppStore).

@gotitbro
Copy link
Author

@vbagirov The test/beta builds are the one that are ultimately published to the App Store, right?
And is the external testers limit still 2000?

@vbagirov
Copy link
Member

@gotitbro that's true; the external testers limit is 2,000 but we still have plenty of room, so don't be worried about that. By test builds I mean those builds that we add to TestFlight. Not necessarily each one of them will be released to AppStore, sometimes we roll out multiple beta builds before finally updating the release version.

ameshkov pushed a commit that referenced this issue Jul 18, 2019
…ster

Squashed commit of the following:

commit 51ab23507d8346b98063560f04d649241789fdff
Author: Ivan Ilin <[email protected]>
Date:   Tue May 21 10:52:40 2019 +0300

    Add validation for custom server name and upstream fields
    #917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants