-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$generichide filters not parsed on iOS [Bug] #255
Comments
Confirmed on also Android.
Manually renamed element was hidden by generiс element hiding rule |
@Alex-302 can you reproduce it in v2.8? |
@ameshkov no. Seems to be works as expected. |
Got it, thank you! Filed a bug report to extension repo (as iOS version shares rules converter with it): @Stillness-2 please update converter when this bug is fixed on extension side. |
@ameshkov @Stillness-2 I see that this issue has been resolved with the Safari extension, any update on when this might be fixed for the iOS app, can't access a lot of websites due to this issue. |
iOS beta with the new converter version should be ready by the end of this week. |
That's great! Hope this will be pushed to stable branch as well soon. |
@ameshkov The recent update for Adguard for iOS (1.1.4) does not fix this issue and also breaks the temporary fix with $elemhide.
More info: https://forum.adguard.com/index.php?threads/ndtv-com-anti-adb-ios.18066/#post-120384 I am left completely helpless as I can't even use the $elemhide modifier now to fix this issue, please help. |
@gotitbro weird, thanks for reporting it. |
@ameshkov Thanks for getting back to me here AdguardTeam/AdguardBrowserExtension#507, I just browsed through some issues and a lot of them seem to be related to this bug, lets push the update for iOS soon as well :) |
@ameshkov Any update on when this might be fixed? Can't access an increasing number of websites due to this bug. |
@gotitbro it was pushed to beta yesterday |
@ameshkov That's good to know, can you tell me how to join the beta? |
@gotitbro yep, here you are: |
@ameshkov Thanks for the link, I have some questions about TestFlight: |
@gotitbro as far as I know, no, you will not be able to. Only test builds appear in TestFlight, and if there are none, you won't be able to use Adguard (unless you have a purchased Pro version or a free version from AppStore). |
@vbagirov The test/beta builds are the one that are ultimately published to the App Store, right? |
@gotitbro that's true; the external testers limit is 2,000 but we still have plenty of room, so don't be worried about that. By test builds I mean those builds that we add to TestFlight. Not necessarily each one of them will be released to AppStore, sometimes we roll out multiple beta builds before finally updating the release version. |
…ster Squashed commit of the following: commit 51ab23507d8346b98063560f04d649241789fdff Author: Ivan Ilin <[email protected]> Date: Tue May 21 10:52:40 2019 +0300 Add validation for custom server name and upstream fields #917
The Adguard Content Blocker for iOS does not parse filters with
$generichide
modifier on Safari iOS but it parses$elemhide
filters.How to reproduce?
Enable "Mobile ads filter" in Adguard (it contains
@@||m.beautypageants.in^$generichide
) and go to http://m.beautypageants.in/ and click on any article, you will get an adb warning which the$generichide
was supposed to fix.Now add this filter:
@@||m.beautypageants.in^$elemhide
to user filters and visit any article on the website again, you will not get an anti adb warning (this means$elemhide
was successfully parsed but$generichide
was not).This can be tested for other sites as well. Please fix this major issue.
Note: Using Mobile Safari 10.0 on iOS 10.1.1 with Adguard 1.1.1
The text was updated successfully, but these errors were encountered: