@@*$generichide issue

[vozersky]

Generichide exceptions don't work correctly in Safari.

STR:

1. Install 2.5.11 extension to Safari
2. Import rules.txt
3. Open:
   www.championat.com
   www.khabar.ndtv.com
   www.bild.de

[vozersky]

duplicates #437

[ameshkov]

@vozersky it is not duplicate I guess, something new.

@Mizzick it appears something is wrong with third-level domains.

Here is a relevant forum discussion:
https://forum.adguard.com/index.php?threads/ndtv-com-anti-adb-ios.18066/

[gotitbro]

@ameshkov $generichide filters don't work even on second level domains. For example:
Add ##img to User Filters and visit github.com all avatars should be hidden even after you add
@@||github.com^$generichide the avatars are still hidden.

[Alex-302]

@gotitbro Can you confirm the same issue with $genericblock exclusions?

[gotitbro]

@Alex-302 $genericblock are working, I checked this by adding @@||timesofindia.com^$genericblock to the User Filter and the visited: http://m.timesofindia.com/world/us/obama-ends-open-door-policy-for-cuban-migrants-white-house/articleshow/56509375.cms

The ads were visible which would have been blocked by generic blocking rules such as ||doubleclick.net^ ads and ||clmbtech.com^ ads were visible.

[Mizzick]

[
	{
		"trigger": {
			"url-filter": ".*"
		},
		"action": {
			"type": "css-display-none",
			"selector": "img"
		}
	},
	{
		"trigger": {
			"url-filter": "^https?://([^/]*\\.)?championat\\.com[/:&?]?",
			"resource-type": [
				"document"
			]
		},
		"action": {
			"type": "ignore-previous-rules"
		}
	}
]

ok, this is a simple content blocker file, produced by only 2 rules:

##img
@@||championat.com^$generichide

but it doesn't work as expected.

[ameshkov]

@Mizzick could it be that resource-type is the culprit?

[Mizzick]

I've tried without, I guess something is wrong with this url-filter

[ameshkov]

@Mizzick shouldn't it be ^https?:\/\/?

[ameshkov]

@Mizzick just experiment with the url-filter then

[Mizzick]

ok, fixed

[ameshkov]

@Mizzick wait a bit, I didn't mean you should get rid of url-filter:)

[Mizzick]

Temporary fixed with "if-domain" triggers

[Mizzick]

After some investigations, we've found that "url-filter" doesn't work properly for css exceptions("ignore-previous-rules" for "css-display-none").
As an example:

Testing on https://lenta.ru
with simple content blocker:

[{trigger: {url-filter: ".*"}, action: {type: "css-display-none", selector: "img"}},
 {trigger: {url-filter: "^https?://([^/]*\\.)?le.*"}, action: {type: "ignore-previous-rules"}}]

These url-filter trigger an exception and first rule is ingored:

                    //"url-filter": "https:*"
                    //"url-filter": "^https?:*"
                    //"url-filter": "^https?://*"
                    //"url-filter": "^https?://([^/]*\\.)?*"
                    //"url-filter": "^https?://([^/]*\\.)?l*"

But these do not:

//"url-filter": "https:\\/\\/lenta\\.ru"
                    //"url-filter": "https://lenta.ru/*"
                    //"url-filter": "https://lenta\\.ru"
                    //"url-filter": "https:\/\/lenta\.ru"
                    //"url-filter": "^https://lenta*"
                    //"url-filter": "^https?://lenta*"
                    //"url-filter": "^https?://icdn.lenta*"
                    //"url-filter": "^https?://lenta.*"
                    //"url-filter": "^https?://([^/]*\\.)?lent*"
                    //"url-filter": "^https?://([^/]*\\.)?le*"

[gotitbro]

@ameshkov @Mizzick Can this be considered fixed then?

[ameshkov]

@gotitbro yep, we've rolled it back to what we had in v2.4

Additionally, I'll file a bug report to WebKit soon.

[gotitbro]

@ameshkov Can you push the fix to iOS as a minor update as well? Been waiting for a long time, can't access a lot of sites due to this bug.

[ameshkov]

@gotitbro sure!