Skip to content

Remove fcp adapter #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Dec 15, 2022
Merged

Remove fcp adapter #1501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
2c3a53c
First pass at removing the cmx_3600 adapter
apetrynet Nov 28, 2022
b190f7c
removed sample data only used by the cmx_3600 adapter
apetrynet Nov 28, 2022
7305fbe
First pass at removing the cmx_3600 adapter
apetrynet Nov 28, 2022
e6268a4
removed sample data only used by the cmx_3600 adapter
apetrynet Nov 28, 2022
3bb804a
replaced imp with importlib
apetrynet Nov 29, 2022
3d47054
print
apetrynet Nov 29, 2022
8a2be00
debugging
apetrynet Nov 29, 2022
07b92ea
Merge branch 'extract_adapters' of github.com:apetrynet/OpenTimelineI…
apetrynet Nov 29, 2022
1e9da45
reverted importlib change. Not meant to be a part of this PR
apetrynet Nov 30, 2022
e641e36
Moving this change to a separate PR
apetrynet Nov 30, 2022
c5027a8
add "extract_adapters" to CI triggers
apetrynet Dec 1, 2022
cfc1f42
reverted test_plugin_detection.py to look for cmx_3600 as it is chang…
apetrynet Dec 1, 2022
8648685
otioz test called for an edl we removed. Replaced with an otio file
apetrynet Dec 1, 2022
61068a2
updated variable name to match new test source
apetrynet Dec 1, 2022
0913d20
converted screening_example.edl to screening_example.otio and used it…
apetrynet Dec 1, 2022
5cb3bcd
First pass at removing the cmx_3600 adapter
apetrynet Nov 28, 2022
b0c7fa0
removed sample data only used by the cmx_3600 adapter
apetrynet Nov 28, 2022
261b12c
replaced imp with importlib
apetrynet Nov 29, 2022
e4c7f93
print
apetrynet Nov 29, 2022
2f31b30
debugging
apetrynet Nov 29, 2022
fc34ac9
reverted importlib change. Not meant to be a part of this PR
apetrynet Nov 30, 2022
4715115
otioz test called for an edl we removed. Replaced with an otio file
apetrynet Dec 1, 2022
87a6b44
updated variable name to match new test source
apetrynet Dec 1, 2022
3f43360
converted screening_example.edl to screening_example.otio and used it…
apetrynet Dec 1, 2022
918c30f
removed other adapter suffixes as they belong to adapters soon to be …
apetrynet Dec 1, 2022
0fe30a8
Merge remote-tracking branch 'origin/extract_adapters' into extract_a…
apetrynet Dec 1, 2022
aba8207
SCREENING_EXAMPLE_PATH is back using the otio version
apetrynet Dec 1, 2022
9bc9d52
autogenerated docs for CMX3600 removed
apetrynet Dec 4, 2022
c9e585e
removing the fcp adapter and it's files
apetrynet Dec 12, 2022
0b3849f
replaced premiere_example.xml with premiere_example.otio to pass cons…
apetrynet Dec 14, 2022
d234b73
Merge branch 'AcademySoftwareFoundation:extract_adapters' into extrac…
apetrynet Dec 14, 2022
ccb9c15
removing the fcp adapter and it's files
apetrynet Dec 12, 2022
25a6f2c
replaced premiere_example.xml with premiere_example.otio to pass cons…
apetrynet Dec 14, 2022
983063a
Merge remote-tracking branch 'origin/remove_fcp_adapter' into remove_…
apetrynet Dec 14, 2022
33ceeb4
updated autogenerated docs
apetrynet Dec 14, 2022
bcf3b90
updated autogenerated docs to catch the removed aaf adapter
apetrynet Dec 14, 2022
012cbc7
removed FIXME comment
apetrynet Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions docs/tutorials/otio-plugins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,26 +33,6 @@ Adapter plugins convert to and from OpenTimelineIO.
[Tutorial on how to write an adapter](write-an-adapter).


### fcp_xml

```
OpenTimelineIO Final Cut Pro 7 XML Adapter.
```

*source*: `opentimelineio/adapters/fcp_xml.py`


*Supported Features (with arguments)*:

- read_from_string:
- input_str
- write_to_string:
- input_otio





### otio_json

```
Expand Down
6 changes: 0 additions & 6 deletions src/py-opentimelineio/opentimelineio/adapters/builtin_adapters.plugin_manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
{
"OTIO_SCHEMA" : "PluginManifest.1",
"adapters": [
{
"OTIO_SCHEMA": "Adapter.1",
"name": "fcp_xml",
"filepath": "fcp_xml.py",
"suffixes": ["xml"]
},
{
"OTIO_SCHEMA" : "Adapter.1",
"name" : "otio_json",
Expand Down
Loading