Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fcp adapter #1501

Merged
merged 37 commits into from
Dec 15, 2022
Merged

Remove fcp adapter #1501

merged 37 commits into from
Dec 15, 2022

Conversation

apetrynet
Copy link
Contributor

Part of the ongoing effort to move adapters to their own repositories. #1386
Removed fcp xml adapter and related tests.
Auto documentation on adapters is updated.

@apetrynet
First pass at removing the cmx_3600 adapter
2c3a53c 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
removed sample data only used by the cmx_3600 adapter
b190f7c 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
First pass at removing the cmx_3600 adapter
7305fbe 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
removed sample data only used by the cmx_3600 adapter
e6268a4 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
replaced imp with importlib
3bb804a 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
print
3d47054 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
debugging
8a2be00 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
Merge branch 'extract_adapters' of github.com:apetrynet/OpenTimelineI…
07b92ea 
…O into extract_adapters
@apetrynet
reverted importlib change. Not meant to be a part of this PR
1e9da45 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
Moving this change to a separate PR
e641e36 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
add "extract_adapters" to CI triggers
c5027a8 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
reverted test_plugin_detection.py to look for cmx_3600 as it is chang…
cfc1f42 
…ed in a separate PR. Will rebase when merged

Signed-off-by: apetrynet <[email protected]>
@apetrynet
otioz test called for an edl we removed. Replaced with an otio file
8648685 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
updated variable name to match new test source
61068a2 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
converted screening_example.edl to screening_example.otio and used it…
0913d20 
… in tests

Signed-off-by: apetrynet <[email protected]>
@apetrynet
First pass at removing the cmx_3600 adapter
5cb3bcd 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
removed sample data only used by the cmx_3600 adapter
b0c7fa0 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
replaced imp with importlib
261b12c 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
print
e4c7f93 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
debugging
2f31b30 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
reverted importlib change. Not meant to be a part of this PR
fc34ac9 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
otioz test called for an edl we removed. Replaced with an otio file
4715115 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
updated variable name to match new test source
87a6b44 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
converted screening_example.edl to screening_example.otio and used it…
3f43360 
… in tests

Signed-off-by: apetrynet <[email protected]>
@apetrynet
removed other adapter suffixes as they belong to adapters soon to be …
918c30f 
…extracted

Signed-off-by: apetrynet <[email protected]>
@apetrynet
Merge remote-tracking branch 'origin/extract_adapters' into extract_a…
0fe30a8 
…dapters

# Conflicts:
#	tests/test_examples.py
@apetrynet
SCREENING_EXAMPLE_PATH is back using the otio version
aba8207 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
autogenerated docs for CMX3600 removed
9bc9d52 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
removing the fcp adapter and it's files
c9e585e 
Signed-off-by: apetrynet <[email protected]>
@apetrynet
replaced premiere_example.xml with premiere_example.otio to pass cons…
0b3849f 
…ole tests.

Signed-off-by: apetrynet <[email protected]>
@apetrynet apetrynet changed the base branch from main to extract_adapters December 14, 2022 23:23
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022 •
edited
Loading

Codecov Report

Merging #1501 (012cbc7) into extract_adapters (7a0a8c7) will decrease coverage by 0.95%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           extract_adapters    #1501      +/-   ##
====================================================
- Coverage             78.24%   77.28%   -0.96%     
====================================================
  Files                   190      188       -2     
  Lines                 18816    17644    -1172     
  Branches               3846     3679     -167     
====================================================
- Hits                  14722    13636    -1086     
+ Misses                 2031     1980      -51     
+ Partials               2063     2028      -35
Flag Coverage Δ
py-unittests 77.28% <100.00%> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_console.py 95.33% <100.00%> (ø)
src/opentimelineio/timeline.h 69.23% <0.00%> (-23.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0a8c7...012cbc7. Read the comment docs.

@apetrynet
removed FIXME comment
012cbc7 
Signed-off-by: apetrynet <[email protected]>
@apetrynet apetrynet merged commit 04e6ab2 into AcademySoftwareFoundation:extract_adapters Dec 15, 2022
rosborne132 pushed a commit to rosborne132/OpenTimelineIO that referenced this pull request Jan 19, 2023
@apetrynet @rosborne132
Remove fcp adapter (AcademySoftwareFoundation#1501)
7d48c32 
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Robert Osborne <[email protected]>
reinecke pushed a commit that referenced this pull request Oct 6, 2023
@apetrynet @reinecke
Remove fcp adapter (#1501)
6f7cde4 
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
reinecke pushed a commit that referenced this pull request Oct 6, 2023
@apetrynet @reinecke
Remove fcp adapter (#1501)
a82b2c5 
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
reinecke pushed a commit that referenced this pull request Apr 4, 2024
@apetrynet @reinecke
Remove fcp adapter (#1501)
78a496e 
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
reinecke pushed a commit that referenced this pull request Apr 12, 2024
@apetrynet @reinecke
Remove fcp adapter (#1501)
cea5344 
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
reinecke pushed a commit that referenced this pull request Apr 12, 2024
@apetrynet @reinecke
Remove fcp adapter (#1501)
907a97b 
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
reinecke pushed a commit that referenced this pull request Jun 12, 2024
@apetrynet @reinecke
Remove fcp adapter (#1501)
0eed8c2 
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
reinecke pushed a commit that referenced this pull request Jun 12, 2024
@apetrynet @reinecke
Remove fcp adapter (#1501)
786dde2 
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
reinecke pushed a commit that referenced this pull request Jun 12, 2024
@apetrynet @reinecke
Remove fcp adapter (#1501)
6adfd23 
* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
reinecke added a commit that referenced this pull request Jun 12, 2024
@reinecke @apetrynet
@markreidvfx @rosborne132 @timlehr
Remove non-core adapters (#1725)
e10fdd2 
* Prepare plugin detection for removal of the cmx_3600 adapter (#1488)

* add "extract_adapters" to CI triggers
* use "otiod" as override example

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Extracted CMX3600 adapter and related sample data and tests (#1487)

* Removed the cmx_3600 adapter
* Removed sample data only used by the cmx_3600 adapter
* Add "extract_adapters" to CI triggers
* otioz test called for an edl we removed. Replaced with an otio file
* Converted screening_example.edl to screening_example.otio and used it in tests
* Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted
* Autogenerated docs for CMX3600 removed

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Extract AAF Adapter from OTIO core and establish separate git repo (#1348)

* Remove AAF adapter
* Add Note about the AAF adapter being moved

Signed-off-by: Mark Reid <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove fcp adapter (#1501)

* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove svg adapter (#1502)

* removed svg adapter and related test files
* updated auto documentation

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove maya sequencer adapter related files (#1520)

* Remove maya adapter related files
* Update docs

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove fcp x xml adapter related files (#1529)

* remove fcp x xml adapter files
* update docs

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* remove hls adapter related files (#1535)

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* remove ale adapter related files (#1536)

* remove ale adapter related files

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove burnins adapter related files (#1537)

* extract burnin files
* remove test

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* extract xges adapter files (#1538)

* extract xges adapter files

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove the remains of "contrib"

* Removed the "contrib" directory tree and all references to the contrib adapters.
* Plugin system, setup and auto doc scripts no longer rely on contrib files.
* Also removed some entries on other adapters left behind in the adapters.md file.
* add README_contrib.md to the manifest

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* fixed `doc-plugins-update` when custom hooks are in environment (#1644)

Signed-off-by: Tim Lehr <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* added support for pathlib.Path filepath arguments for adapter IO functions (#1704)

Signed-off-by: Tim Lehr <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Removed orphaned FCP XML adapter post-rebase.

Signed-off-by: Eric Reinecke <[email protected]>

* Update README.md to point users to the adapter repos

Co-authored-by: Daniel Flehner Heen <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Updated documentation about adapters to better reflect the current landscape

Signed-off-by: Eric Reinecke <[email protected]>

* Removed contrib plugin manifest from package data

Signed-off-by: Eric Reinecke <[email protected]>

* Removed extract_adapters branch from CI references

Signed-off-by: Eric Reinecke <[email protected]>

---------

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Mark Reid <[email protected]>
Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Tim Lehr <[email protected]>
Co-authored-by: Daniel Flehner Heen <[email protected]>
Co-authored-by: Mark Reid <[email protected]>
Co-authored-by: Rob Osborne <[email protected]>
Co-authored-by: Tim Lehr <[email protected]>
darbyjohnston pushed a commit to darbyjohnston/OpenTimelineIO that referenced this pull request Jun 14, 2024
@reinecke @apetrynet
@markreidvfx @rosborne132 @timlehr @darbyjohnston
Remove non-core adapters (AcademySoftwareFoundation#1725)
15eac94 
* Prepare plugin detection for removal of the cmx_3600 adapter (AcademySoftwareFoundation#1488)

* add "extract_adapters" to CI triggers
* use "otiod" as override example

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Extracted CMX3600 adapter and related sample data and tests (AcademySoftwareFoundation#1487)

* Removed the cmx_3600 adapter
* Removed sample data only used by the cmx_3600 adapter
* Add "extract_adapters" to CI triggers
* otioz test called for an edl we removed. Replaced with an otio file
* Converted screening_example.edl to screening_example.otio and used it in tests
* Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted
* Autogenerated docs for CMX3600 removed

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Extract AAF Adapter from OTIO core and establish separate git repo (AcademySoftwareFoundation#1348)

* Remove AAF adapter
* Add Note about the AAF adapter being moved

Signed-off-by: Mark Reid <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove fcp adapter (AcademySoftwareFoundation#1501)

* removing the fcp adapter and it's test files
* replaced premiere_example.xml with premiere_example.otio to pass console tests.
* updated auto generated docs

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove svg adapter (AcademySoftwareFoundation#1502)

* removed svg adapter and related test files
* updated auto documentation

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove maya sequencer adapter related files (AcademySoftwareFoundation#1520)

* Remove maya adapter related files
* Update docs

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove fcp x xml adapter related files (AcademySoftwareFoundation#1529)

* remove fcp x xml adapter files
* update docs

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* remove hls adapter related files (AcademySoftwareFoundation#1535)

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* remove ale adapter related files (AcademySoftwareFoundation#1536)

* remove ale adapter related files

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove burnins adapter related files (AcademySoftwareFoundation#1537)

* extract burnin files
* remove test

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* extract xges adapter files (AcademySoftwareFoundation#1538)

* extract xges adapter files

Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Remove the remains of "contrib"

* Removed the "contrib" directory tree and all references to the contrib adapters.
* Plugin system, setup and auto doc scripts no longer rely on contrib files.
* Also removed some entries on other adapters left behind in the adapters.md file.
* add README_contrib.md to the manifest

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* fixed `doc-plugins-update` when custom hooks are in environment (AcademySoftwareFoundation#1644)

Signed-off-by: Tim Lehr <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* added support for pathlib.Path filepath arguments for adapter IO functions (AcademySoftwareFoundation#1704)

Signed-off-by: Tim Lehr <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Removed orphaned FCP XML adapter post-rebase.

Signed-off-by: Eric Reinecke <[email protected]>

* Update README.md to point users to the adapter repos

Co-authored-by: Daniel Flehner Heen <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>

* Updated documentation about adapters to better reflect the current landscape

Signed-off-by: Eric Reinecke <[email protected]>

* Removed contrib plugin manifest from package data

Signed-off-by: Eric Reinecke <[email protected]>

* Removed extract_adapters branch from CI references

Signed-off-by: Eric Reinecke <[email protected]>

---------

Signed-off-by: apetrynet <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Mark Reid <[email protected]>
Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: Tim Lehr <[email protected]>
Co-authored-by: Daniel Flehner Heen <[email protected]>
Co-authored-by: Mark Reid <[email protected]>
Co-authored-by: Rob Osborne <[email protected]>
Co-authored-by: Tim Lehr <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apetrynet @codecov-commenter