Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNMD API to create a new metadata handle and implement IMetaDataDispenser::DefineScope #49

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Add DNMD API to create a new metadata handle and implement IMetaDataDispenser::DefineScope #49

merged 10 commits into from
Jan 18, 2024

Commits on Dec 7, 2023

  1. Add DNMD API to create a new metadata handle with the aboslute minimu… 

    …m metadata required to be valid.
    @jkoritzinsky
    jkoritzinsky committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    583a853 View commit details
    Browse the repository at this point in the history

  2. Implement IMetaDataDispenser::DefineScope to use the new md_create_ne… 

    …w_handle() API.
    @jkoritzinsky
    jkoritzinsky committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b652b4f View commit details
    Browse the repository at this point in the history

  3. Fix error handling for PAL_CoCreateGuid

    @jkoritzinsky
    jkoritzinsky committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    eddb305 View commit details
    Browse the repository at this point in the history

  4. Fix build and add another constructor to DNMDOwner for scenarios wher… 

    …e we don't have the option for the handle to own the external metadata memory (like this case where we never own it)
    @jkoritzinsky
    jkoritzinsky committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    5b8a158 View commit details
    Browse the repository at this point in the history

  5. Update src/interfaces/dispenser.cpp

    @jkoritzinsky
    jkoritzinsky authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    c6d6069 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <[email protected]>
    @jkoritzinsky @AaronRobinsonMSFT
    jkoritzinsky and AaronRobinsonMSFT authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    b51945b View commit details
    Browse the repository at this point in the history

  2. Add comments

    @jkoritzinsky
    jkoritzinsky committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3697d07 View commit details
    Browse the repository at this point in the history

  3. Add a PDB creation method, fix the version number, and add more comments

    @jkoritzinsky
    jkoritzinsky committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3d6569e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'new-dnmd' of github.com:jkoritzinsky/DNMD into new-dnmd

    @jkoritzinsky
    jkoritzinsky committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    bd26a5a View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <[email protected]>
    @jkoritzinsky @AaronRobinsonMSFT
    jkoritzinsky and AaronRobinsonMSFT authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6c51c17 View commit details
    Browse the repository at this point in the history