Add DNMD API to create a new metadata handle and implement IMetaDataDispenser::DefineScope #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m metadata required to be valid.
…e we don't have the option for the handle to own the external metadata memory (like this case where we never own it)
jkoritzinsky
commented
Dec 7, 2023
AaronRobinsonMSFT
approved these changes
Jan 18, 2024
Co-authored-by: Aaron Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new API so we can create images with DNMD (and use them to create bespoke images for testing corner cases in metadata logic).
Also, implement
IMetaDataDispenser::DefineScopewith this API. Since we don't have anIMetaDataEmitimplementation yet, it's not really useful as you get a read-only view to a newly created module, but once we addIMetaDataEmitsupport, it'll be very quick to enable the support for editing.