tests: add configuration to verify that MathOnFloatProcessor does skip repairs for Incomplete cases #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
force-pushed
the
fix-S2164
branch
from
dc5dcaf
to
8f4ce5c
Compare
algomaster99
force-pushed
the
incomplete-processor-test
branch
from
0e72d39
to
8bd8a3c
Compare
khaes-kth
changed the title
khaes-kth
pushed a commit
that referenced
this pull request
Aug 22, 2022
* Fix repair for S2164: Math should not be performed on floats * Update generated field * Update repair description * Verify repair for field * Improve coverage * tests: add configuration to verify that MathOnFloatProcessor does skip repairs for Incomplete cases (#868) * Add test to verify that INCOMPLETE processor skip repairs * Assert that the repaired file compiles * Add docstrings * Add information about `INCOMPLETE` processor tests * Strengthen test * Assume that the parent of CtBinaryOperator will always be a CtTypedElement * Remove redundant methods * Simplify canRepairInternal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt the test was necessary so that we are sure that the violation is being detected, but we are intentionally not repairing it.