fix: mark MathOnFloatProcessor as incomplete
#866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
commented
Aug 19, 2022
| binaryOperator.setType(getFactory().Type().doublePrimitiveType()); | ||
| } | ||
| // We do not need to cast the type of the right hand operand as it is already a | ||
| // double |
There was a problem hiding this comment.
@monperrus not related to autocompletion, but when I deleted the above code, the inline comment was suggested by co-pilot. 🤌🏼
algomaster99
changed the title
MathOnFloatProcessor as incompleteMathOnFloatProcessor as incomplete
|
Please merge this once #868 is merged into this PR. |
algomaster99
force-pushed
the
fix-S2164
branch
from
dc5dcaf
to
8f4ce5c
Compare
…p repairs for Incomplete cases (#868) * Add test to verify that INCOMPLETE processor skip repairs * Assert that the repaired file compiles * Add docstrings * Add information about `INCOMPLETE` processor tests * Strengthen test
algomaster99
changed the title
MathOnFloatProcessor as incompleteMathOnFloatProcessor as incomplete
khaes-kth
approved these changes
Aug 22, 2022
|
That would be better if we could add a test to cover line 86 of this file: https://app.codecov.io/gh/SpoonLabs/sorald/compare/866/changes#D1L86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the ignored tests was bothering me for some time so I though I should fix it. It turned out that resolving the bug stated in #570 required some more dependent fixes and refactoring so I proceeded with them as well. Here is the summary of the list of changes in this PR.
MathOnFloatProcessoris marked as incomplete. It won't attempt to repair when the expected type of theCtVariableisfloatas it produces a non-compilable output.double, but that is not necessary as JVM implicitly does type coercion.