Skip to content

fix(kanban): name failed git operation and returncode in survivor hold - #941

Merged
Kyzcreig merged 1 commit into
mainfrom
fix/survivor-git-diagnostic-reported-t_1e7a5864
Sep 23, 2026
Merged

Kyzcreig merged 1 commit into
mainfrom
fix/survivor-git-diagnostic-reported-t_1e7a5864

Conversation

@Kyzcreig

@Kyzcreig Kyzcreig commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Verification

  • RED on main with adapted tests: 2 failed (both reasons were survivor_unavailable: git inspection failed).
  • GREEN on branch: PYTHONPATH="$PWD" HERMES_HOME=/tmp/t_1e7a5864-test ~/.hermes/hermes-agent/.venv/bin/python -P -m pytest -q tests/hermes_cli/test_kanban_survivor_authority.py -k 'git_failure_' -o addopts='' → 2 passed, 7 deselected.
  • PYTHONPATH="$PWD" HERMES_HOME=/tmp/t_1e7a5864-test ~/.hermes/hermes-agent/.venv/bin/python -P -m pytest -q tests/hermes_cli/test_kanban_survivor.py tests/hermes_cli/test_kanban_survivor_authority.py tests/hermes_cli/test_kanban_survivor_broken_object_store.py -o addopts='' → 56 passed in 65.54s.
  • git diff --check clean.

Supersedes #859. This branch is independent of the in-flight #924 survivor port: coordinate merge order with Apollo after Argus records #924's review.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Reuse the existing redacted stderr log; persist only the static Git operation and numeric returncode. Adapt the existing authority tests for both environment failures and redacted credential-bearing stderr. Verified 56 survivor tests on the isolated fork/main checkout.
@Kyzcreig

Copy link
Copy Markdown
Collaborator Author

🤖 merged-by: apollo · lane: t_1e7a5864 · gate: BYPASS: FleetReview disabled fleet-wide (Ace 2026-09-22); gate = kanban Argus-APPROVED review + CI green + 0 conflicts · why: Argus APPROVED (PASS-WITH-CAVEATS) @ a214408: kanban survivor names the failed git op + rc; diagnostic RED on fork/main GREEN on PR; CI green

@Kyzcreig
Kyzcreig marked this pull request as ready for review September 23, 2026 19:48
@Kyzcreig

Copy link
Copy Markdown
Collaborator Author

🤖 merged-by: apollo · lane: t_1e7a5864 · gate: BYPASS: FleetReview disabled fleet-wide (Ace 2026-09-22); gate = kanban Argus-APPROVED review + CI green + 0 conflicts · why: Argus APPROVED (PASS-WITH-CAVEATS) @ a214408: kanban survivor names the failed git op + rc; diagnostic RED on fork/main GREEN on PR; CI green; undrafted by Apollo

@Kyzcreig
Kyzcreig added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit 1483eb2 Sep 23, 2026
54 checks passed
@Kyzcreig
Kyzcreig deleted the fix/survivor-git-diagnostic-reported-t_1e7a5864 branch September 23, 2026 20:29
@Kyzcreig Kyzcreig added the fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent) label Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant