fix(kanban): name failed git operation and returncode in survivor hold - #941
Merged
Merged
Conversation
Reuse the existing redacted stderr log; persist only the static Git operation and numeric returncode. Adapt the existing authority tests for both environment failures and redacted credential-bearing stderr. Verified 56 survivor tests on the isolated fork/main checkout.
Collaborator
Author
|
🤖 merged-by: apollo · lane: t_1e7a5864 · gate: BYPASS: FleetReview disabled fleet-wide (Ace 2026-09-22); gate = kanban Argus-APPROVED review + CI green + 0 conflicts · why: Argus APPROVED (PASS-WITH-CAVEATS) @ a214408: kanban survivor names the failed git op + rc; diagnostic RED on fork/main GREEN on PR; CI green |
Kyzcreig
marked this pull request as ready for review
September 23, 2026 19:48
Collaborator
Author
|
🤖 merged-by: apollo · lane: t_1e7a5864 · gate: BYPASS: FleetReview disabled fleet-wide (Ace 2026-09-22); gate = kanban Argus-APPROVED review + CI green + 0 conflicts · why: Argus APPROVED (PASS-WITH-CAVEATS) @ a214408: kanban survivor names the failed git op + rc; diagnostic RED on fork/main GREEN on PR; CI green; undrafted by Apollo |
Kyzcreig
deleted the
fix/survivor-git-diagnostic-reported-t_1e7a5864
branch
September 23, 2026 20:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_git()now persists the Git subcommand and returncode in a survivor hold, not the opaquegit inspection failedmessage._git(input=)signature and existing redacted warning from fix(kanban): log git's returncode and stderr when survivor capture fails #856 rather than duplicating stderr handling._record()and its post-kanban: reclamation consults the RECORDED survivor instead of re-deriving from stale bases #842/fix(kanban): bind an explicit survivor claim to the card that names it #848/fix(kanban): close the 4 P1 FleetReview recorded on #848's head 0757be86 #886 paths are untouched.test_kanban_survivor_authority.pyto assert the new reason and ensure credential-bearing stderr stays out of the reason and log. The separate test introduced in fix(kanban): name the git subcommand and returncode in survivor holds #859 is redundant with these tests on main.Verification
survivor_unavailable: git inspection failed).PYTHONPATH="$PWD" HERMES_HOME=/tmp/t_1e7a5864-test ~/.hermes/hermes-agent/.venv/bin/python -P -m pytest -q tests/hermes_cli/test_kanban_survivor_authority.py -k 'git_failure_' -o addopts=''→ 2 passed, 7 deselected.PYTHONPATH="$PWD" HERMES_HOME=/tmp/t_1e7a5864-test ~/.hermes/hermes-agent/.venv/bin/python -P -m pytest -q tests/hermes_cli/test_kanban_survivor.py tests/hermes_cli/test_kanban_survivor_authority.py tests/hermes_cli/test_kanban_survivor_broken_object_store.py -o addopts=''→ 56 passed in 65.54s.git diff --checkclean.Supersedes #859. This branch is independent of the in-flight #924 survivor port: coordinate merge order with Apollo after Argus records #924's review.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.