Skip to content

fix(kanban): re-port canonical survivor binding onto current main - #924

Merged
Kyzcreig merged 5 commits into
mainfrom
kanban/survivor-rewrite-report-t_5e1b2a5a
Sep 23, 2026
Merged

Kyzcreig merged 5 commits into
mainfrom
kanban/survivor-rewrite-report-t_5e1b2a5a

Conversation

@Kyzcreig

@Kyzcreig Kyzcreig commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Verify

  • On fork/main 034f8d1, test_home_clone_closes_against_the_live_tree failed (bundle instead of canonical ref), and test_rewritten_mirror_over_cap_uses_live_tree_instead failed with implementation artifact exceeds attachment limit; both pass on this branch. The independent collision refusal (test_diff_collision_over_attachment_limit_holds_workspace) remains green both before and after: its refusal is intentional, not a second failing bug.
  • test_kanban_survivor_live_tree.py test_kanban_survivor_landed.py test_kanban_survivor_storage.py: 65 passed before the late fix(kanban): preserve home-clone work via verified canonical live trees #796 live-HEAD addition; its five tests passed separately after port. New cap-specific test passed on branch.
  • test_kanban_survivor_stale_bases.py test_kanban_survivor_binding.py tests/tools/test_kanban_tool_survivor.py test_kanban_survivor.py test_kanban_survivor_848_findings.py: 168 passed.
  • All runs use the hermes-agent venv with throwaway HOME/HERMES_HOME, PYTHONPATH=$PWD, Python -P and -p no:randomly.

Supersedes #796; requires independent review before integration.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Retain live-tree and byte-exact landed authority without replacing main preservation and non-shrink logic. Verified mirror and over-cap red on main, green on branch; 65 original port tests, five new live-head tests, and 168 main survivor/tool regressions passed.
Verify: 65 focused and 112 required survivor tests passed; replace-ref and inherited-path regressions red before fix and green after; ref-cost gate restored.
Verified real completion regression red before fix, 194 survivor and ref-cost tests passed after; git diff --check clean.
Verified real completion retains vanished child repo bytes; seven-file survivor suite: 196 passed in 1260.59s.
@Kyzcreig
Kyzcreig force-pushed the kanban/survivor-rewrite-report-t_5e1b2a5a branch from 7b6876c to 11f0d22 Compare September 23, 2026 15:20
Real completion distinguishes bound rescue reclamation from unbound hold. M2/M3/M4 source mutants fail the respective assertions; required survivor tests plus live-tree suite: 150 passed.
@Kyzcreig

Copy link
Copy Markdown
Collaborator Author

🤖 merged-by: apollo · lane: t_5e1b2a5a · gate: BYPASS: FleetReview disabled fleet-wide (Ace 2026-09-22); gate = kanban Argus-APPROVED review + CI green + 0 conflicts · why: Argus APPROVED (PASS-WITH-CAVEATS/SHIP) @ e088b4c: re-port canonical survivor binding; bound/unbound cleanup contract 150/150 on branch + merge tree; CI green

@Kyzcreig
Kyzcreig marked this pull request as ready for review September 23, 2026 19:48
@Kyzcreig

Copy link
Copy Markdown
Collaborator Author

🤖 merged-by: apollo · lane: t_5e1b2a5a · gate: BYPASS: FleetReview disabled fleet-wide (Ace 2026-09-22); gate = kanban Argus-APPROVED review + CI green + 0 conflicts · why: Argus APPROVED (PASS-WITH-CAVEATS/SHIP) @ e088b4c: re-port canonical survivor binding; bound/unbound cleanup contract 150/150; CI green; undrafted by Apollo

@Kyzcreig
Kyzcreig added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit 6902fa6 Sep 23, 2026
54 checks passed
@Kyzcreig
Kyzcreig deleted the kanban/survivor-rewrite-report-t_5e1b2a5a branch September 23, 2026 20:33
@Kyzcreig Kyzcreig added the fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent) label Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant