fix: C3 re-bucket follow-up, 9 FleetReview rows (t_7da6cadf) - #1393
Conversation
…1032, #1043, #1095, #1198, #1254:121) (t_7da6cadf) - #942: desktop hydration accepts a tool-call confab notice on an empty system row (mirrors notice_from_display_row); per-kind label. - #970: switch_model(probe_catalog=False) passes allow_network through get_label / determine_api_mode; cold models.dev cache opens no socket. - #976: _build_hyg_agent / hygiene get_session use the _hyg_old_sid snapshot. - #1043: post-turn clear_resume_pending keeps a mark written during the turn. - #1095: an early-imported bundled provider module is re-registered in the bundled discovery step (filesystem over pip precedence). - #1198: cooling_providers ignores runtime-stage pin refusals. - #1254:121: process_env_files overlay pre-values ride to child agent processes (HERMES_PROCESS_ENV_OVERLAY) so strip_overlay works there. - #1032: store-level model resolution that changes the provider re-runs the base_url exfil guard at write time. Verified: new tests fail on fork/main (8/8), pass on head; neighbouring suites pass (see PR).
|
🤖 merged-by: apollo · lane: kanban-merge-pass · gate: ADVISORY (FleetReview not green for 99cc8fc): fleetreview-advisory-20260927-standing.md · why: t_7da6cadf: C3 re-bucket follow-up: 23 confirmed-TRUE rows not fixed in t_e038f946 (hermes-a; Argus off card review (Ace 13:08), CI green |
FleetReviewReview: post-merge · head
Post-merge review ( Reviewed with 1 of 2 model families — xai unavailable. profile: light (rule: default light: lines 494<800, files 15<1000000, hunks 43<1000000, no hot path) · round 0 · members: B-assert-ctx, B-state, F, G · families: openai Confidence: 1/5 Findings
FleetReview provenance · models: B=gpt-6-sol, D=grok-4.6, F=gpt-6-sol · cost: $6.54 · duration: 19m 48s · rounds: 2 · files examined: 15 |
FleetReviewFleetReview's daily member-call budget is spent (60/600 for 2026-09-28 UTC); review skipped. FleetReview · reviewKind: skipped-budget |
Kanban t_7da6cadf (child of t_e038f946; the hermes-agent rows not in #1389).
Fixed. Each row has a test that fails on fork/main d9a5c53 and passes on head:
confabNoticeFromRownow mirrors Pythonnotice_from_display_row: a system row may carry a tool-call notice (kind tool_call_as_text / tool_call_unparseable, scope visible). Desktop hydration renders it with a per-kind label. A scaffold catch on a system row is still refusedget_labelanddetermine_api_modetakeallow_network.switch_modelpassesprobe_catalogthrough_build_hyg_agentand the hygieneget_sessionuse the_hyg_old_sidsnapshotlast_resume_marked_atat run start.clear_resume_pending(key, marked_at=...)keeps a mark written after that snapshot. Legacy callers (no kwarg) behave as beforeregister_providerrecords its calling module._import_plugin_dirreplays that module's registrations when the module is already in sys.modulesHERMES_PROCESS_ENV_OVERLAY. A child agent process seeds_OVERLAYfrom it, andstrip_overlaydrops the marker_revalidate_resolved_providerre-runs_validate_cron_base_urlwhen store resolution (auto sentinel, alias, legacy heal) changed the provider. It runs in create_job and update_job and raises ValueError, the same pattern as reasoning_effortNot fixed, these need a decision (details on card t_7da6cadf):
Local narrow runs, via test-gate, one file group per run:
Breadth is CI's.
Collisions: gateway/run.py is a hotspot (dispatcher warned about t_2fc8913a and t_a00223ec). My hunks are small: the hygiene block, the run-start snapshot, and the gate signature. process_env_files.py is also touched by #1389, in different functions.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.