Skip to content

fix: C3 re-bucket, 4 FleetReview instances (#987, #1054, #1254 x2) (t_e038f946) - #1389

Merged
ang-fleet-lander[bot] merged 1 commit into
mainfrom
fix/c3-rebucket-t_e038f946
Sep 28, 2026
Merged

ang-fleet-lander[bot] merged 1 commit into
mainfrom
fix/c3-rebucket-t_e038f946

Conversation

@ang-fleet-workers

@ang-fleet-workers ang-fleet-workers Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

FleetReview rows filed as secret-pii, re-bucketed (per-row table on card t_e038f946). Re-verified at fork/main 2a63e2c.

Tests: 4 new, all fail on base and pass on head; the three touched test files 15/15.

Deferred TRUE rows (follow-up card): #942 system tool notice hydration (x2), #970 cold-cache test, #976 hygiene sid pin, #1032 cron auto provider revalidation, #1043 resume-mark clear race, #1053 raw get_range, #1095 provider precedence, #1101 interrupt-close omission, #1198 stage-blind cooldown, #1254 :121 inherited overlay. #942 turn_finalizer:336 = FP.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

#987 kanban notifier home-line lookup opens state.db read-only.
#1054 archive_and_compact counts duplicate result rows, so a third copy of an
already-duplicated tool_call_id is refused.
#1254 process_env_files: a file that exports then fails is not applied;
relative paths are made absolute before POSIX '.'.
4 new tests fail on base, pass on head.
@ang-prism

ang-prism Bot commented Sep 28, 2026

Copy link
Copy Markdown

FleetReview

Review: pre-merge · head b50d85b5680e · duration 2m 46s
Profile: light (merit: default light: lines 95<800, files 6<1000000, hunks 8<1000000, no hot path) · policy: below-size-and-path-gates
Roster: B-assert-ctx → gpt-6-sol (openai), C-assert-xhigh → gpt-6-sol (openai), F → gpt-6-sol (openai), L6 → gpt-6-sol (openai)

PARTIAL — ensemble escalated: family floor: too few distinct model families completed

This review did not reach a trusted verdict, so it is not a gate pass and the findings below may be incomplete. They are posted so they can be read rather than lost in a terminal record.

Reviewed with 1 of 2 model families — anthropic unavailable.

profile: light (rule: default light: lines 95<800, files 6<1000000, hunks 8<1000000, no hot path) · round 0 · members: B-assert-ctx, L6, C-assert-xhigh, F · families: openai

Confidence: 1/5

Findings

  • P1 hermes_cli/process_env_files.py:73 — Ignored errexit · agreed: B-assert-ctx,F (openai)
  • P1 hermes_state.py:13636 — Count-only comparison still publishes newly duplicated tool results · agreed: C-assert-xhigh (openai)

FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, F=gpt-6-sol · cost: $0.95 · duration: 2m 43s · rounds: 2 · files examined: 6

@ang-fleet-lander

Copy link
Copy Markdown

🤖 merged-by: apollo · lane: kanban-merge-pass · gate: ADVISORY (FleetReview not green for b50d85b): fleetreview-advisory-20260927-standing.md · why: t_e038f946: C3 re-bucket: 50 findings the classifier mis-filed as secret/PII (keyed on 'tran; Argus off card review (Ace 13:08), CI green

@ang-fleet-lander
ang-fleet-lander Bot added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit 7d5b288 Sep 28, 2026
47 checks passed
@ang-fleet-lander
ang-fleet-lander Bot deleted the fix/c3-rebucket-t_e038f946 branch September 28, 2026 03:39
@ang-fleet-ci-actuators ang-fleet-ci-actuators Bot added the fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent) label Sep 28, 2026
@ang-prism

ang-prism Bot commented Sep 28, 2026

Copy link
Copy Markdown

FleetReview

Review: post-merge · head 7d5b288a8103 · duration 12m 03s
Profile: light (merit: default light: lines 95<800, files 6<1000000, hunks 8<1000000, no hot path) · policy: below-size-and-path-gates
Roster: B-assert-ctx → gpt-6-sol (openai), B-state → gpt-6-sol (openai), F → gpt-6-sol (openai), G → gpt-6-sol (openai)

PARTIAL — ensemble escalated: family floor: too few distinct model families completed

This review did not reach a trusted verdict, so it is not a gate pass and the findings below may be incomplete. They are posted so they can be read rather than lost in a terminal record.

Post-merge review (fleetreview:post-merge override): this reviewed the merge commit against its first parent — the bytes that already shipped. It is not a pre-merge gate pass.

Reviewed with 1 of 2 model families — xai unavailable.

profile: light (rule: default light: lines 95<800, files 6<1000000, hunks 8<1000000, no hot path) · round 0 · members: B-assert-ctx, B-state, F, G · families: openai

Confidence: 1/5

Findings

  • P1 hermes_cli/process_env_files.py:73 — Ignored errexit · agreed: B-assert-ctx,F,G (openai)

FleetReview provenance · models: B=gpt-6-sol, D=grok-4.6, F=gpt-6-sol · cost: $0.81 · duration: 12m 00s · rounds: 2 · files examined: 6

@ang-prism

ang-prism Bot commented Sep 28, 2026

Copy link
Copy Markdown

FleetReview

FleetReview's daily member-call budget is spent (60/600 for 2026-09-28 UTC); review skipped.


FleetReview · reviewKind: skipped-budget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants