Repository navigation
test(redact): leaf guard uses os.walk — rglob raced vanishing scratch dirs (5 PRs red) - #1239
Merged
Merged
Conversation
…sts' vanishing scratch dirs test_no_serialize_then_redact_text_call_sites rglob'd the repo root; parallel tests create and delete hermes_agent-* dirs there, so rglob raised FileNotFoundError mid-walk (CI 2026-09-26: 5 PRs red on it). os.walk ignores vanished dirs; read errors skipped. Repro: churned dir -> rglob 6/40 raises, os.walk 0/40. 28 passed.
|
🤖 merged-by: apollo · lane: kanban-merge-pass · gate: BYPASS: FleetReview paused since 09-22; gate = CI green + Apollo diff review · why: ROOT-CAUSE: redact leaf-guard rglob race ejecting PRs (5 red); os.walk; repro rglob 6/40 vs walk 0/40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of
tests/agent/test_redact_json_leaf.py::test_no_serialize_then_redact_text_call_sitesfailing on 5 PRs (#1118 #1116 #1218 #1223 #1225):REPO.rglobraisesFileNotFoundErrorwhen a parallel test's scratch dir (hermes_agent-0.20.6) vanishes mid-walk. Switch toos.walk(ignores vanished dirs), skip unreadable files. Repro with a churned dir: rglob raised 6/40, os.walk 0/40. 28/28 local.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.