Repository navigation
ci(js-tests): shard desktop check:test:ui 3 ways — merge-group critical path - #1225
Merged
Merged
Conversation
merge_group run 36217656078: "JS & TS checks" took 11m26s, 656.7s of it in apps/desktop check:test:ui (685 files, 6774 tests; vitest worker time import 747s + environment 644s + tests 329s). The other 9 checks finished by 04:27. That one unit was the merge group's critical path. - ui-tests job: vitest --project ui --shard=N/3, matrix 1..3, fail-fast off - check job: run-workspace-checks.mjs --skip apps/desktop::check:test:ui - run-workspace-checks.mjs: repeatable --skip; a skip matching no unit exits 1 so a rename cannot drop the suite from both jobs - .github/actions/node-workspace: the setup-node/npm12/node_modules-cache/ install steps, shared so all 4 jobs hit one cache key Verified: --list with the skip shows 9 units (10 without); a bogus --skip exits 1; actionlint clean on js-tests.yml. Shard file parity is checked on the CI run (sum of per-shard Test Files == 685).
|
Found 2 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.svg)
ang-fleet-interactive
Bot
added
the
ci-reviewed
|
🤖 merged-by: apollo · lane: discord · gate: BYPASS: FR paused by Ace 2026-09-22; Argus off card review (Ace 09-24 13:08); gate = handoff + CI green + Apollo read (review-of-record on card) · why: js-tests shard 3 ways (critical path) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kanban t_bc0f3f62. The merge-group critical path was the single
JS & TS checksjob.Profile of merge_group run 36217656078, job 108336862445 (ubuntu-latest, 4 cores):
apps/desktop :: check:test:ui: 656.7s (685 files, 6774 tests). vitest worker time: import 747s + environment 644s + tests 329s + transform 100s + setup 83s. This is per-file jsdom and import cost, so it splits linearly by file.Change:
ui-testsmatrix job runsvitest --project ui --shard=N/3with N = 1..3 and fail-fast off. It is the same command ascheck:test:ui(npm run test:ui) with a shard flag added.checkjob runsrun-workspace-checks.mjs --skip apps/desktop::check:test:ui.--skipexits 1 when it matches no unit. If the script is renamed, the suite cannot quietly drop out of both jobs..github/actions/node-workspacecomposite holds the setup, npm12, cache and install steps. All 4 jobs share it, so they cannot end up on different cache keys.The only required context is
All required checks pass, and it still depends onjs-tests(the reusable workflow result aggregates every inner job). Job ids in ci.yaml and evaluate_needs are unchanged.Coverage parity: in CI, the per-shard
Test Filescounts must sum to 685 andTestsmust sum to 6774, the same as the unsharded run.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.